qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 3/3] configure: mark vhost-user Linux-only
Date: Wed, 11 Nov 2020 10:23:42 +0100	[thread overview]
Message-ID: <dd717b66-22fa-9bb5-dfcd-9191d743401d@redhat.com> (raw)
In-Reply-To: <20201110171121.1265142-4-stefanha@redhat.com>

On 11/10/20 6:11 PM, Stefan Hajnoczi wrote:
> The vhost-user protocol uses the Linux eventfd feature and is typically
> connected to Linux kvm.ko ioeventfd and irqfd file descriptors. The
> protocol specification in docs/interop/vhost-user.rst does not describe
> how platforms without eventfd support work.
> 
> The QEMU vhost-user devices compile on other POSIX host operating
> systems because eventfd usage is abstracted in QEMU. The libvhost-user
> programs in contrib/ do not compile but we failed to notice since they
> are not built by default.
> 
> Make it clear that vhost-user is only supported on Linux for the time
> being. If someone wishes to support it on other platforms then the
> details can be added to vhost-user.rst and CI jobs can test the feature
> to prevent bitrot.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  configure | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>



      parent reply	other threads:[~2020-11-11  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 17:11 [PATCH 0/3] vhost-user: ./configure improvements for 5.2 Stefan Hajnoczi
2020-11-10 17:11 ` [PATCH 1/3] meson: move vhost_user_blk_server to meson.build Stefan Hajnoczi
2020-11-11  9:41   ` Philippe Mathieu-Daudé
2020-11-11 11:44     ` Philippe Mathieu-Daudé
2020-11-11 11:54       ` Philippe Mathieu-Daudé
2020-11-12 10:58         ` Stefan Hajnoczi
2020-11-10 17:11 ` [PATCH 2/3] vhost-user-blk-server: depend on CONFIG_VHOST_USER Stefan Hajnoczi
2020-11-11  9:25   ` Philippe Mathieu-Daudé
2020-11-11 14:16     ` Stefan Hajnoczi
2020-11-10 17:11 ` [PATCH 3/3] configure: mark vhost-user Linux-only Stefan Hajnoczi
2020-11-10 17:44   ` Thomas Huth
2020-11-11  9:23   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd717b66-22fa-9bb5-dfcd-9191d743401d@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).