From: Richard Henderson <richard.henderson@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>,
Stefano Stabellini <sstabellini@kernel.org>,
peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PULL v3 0/10] xenpvh3-tag
Date: Thu, 4 May 2023 07:34:55 +0100 [thread overview]
Message-ID: <dd7325e0-7db1-3b1f-7ce1-319aa58ebd1f@linaro.org> (raw)
In-Reply-To: <1f6b3666-fc7e-083a-50fb-b2e91ac2c012@amd.com>
On 5/4/23 06:18, Vikram Garhwal wrote:
> Hi Richard,
>
> On 5/3/23 12:47 AM, Richard Henderson wrote:
>> On 5/3/23 01:12, Stefano Stabellini wrote:
>>> Hi Peter,
>>>
>>> Vikram fixed the gitlab test problem, so now all the tests should
>>> succeed. There were no changes to the QEMU code. I am resending the pull
>>> request (I rebased it on staging, no conflicts.)
>>>
>>> For reference this was the previous pull request:
>>> https://marc.info/?l=qemu-devel&m=167641819725964
>>>
>>> Cheers,
>>>
>>> Stefano
>>>
>>>
>>> The following changes since commit 4ebc33f3f3b656ebf62112daca6aa0f8019b4891:
>>>
>>> Merge tag 'pull-tcg-20230502-2' of https://gitlab.com/rth7680/qemu into staging
>>> (2023-05-02 21:18:45 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>> https://gitlab.com/sstabellini/qemu xenpvh3-tag
>>>
>>> for you to fetch changes up to bc618c54318cbc2fcb9decf9d4c193cc336a0dbc:
>>>
>>> meson.build: enable xenpv machine build for ARM (2023-05-02 17:04:54 -0700)
>>>
>>> ----------------------------------------------------------------
>>> Stefano Stabellini (5):
>>> hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState
>>> xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common
>>> include/hw/xen/xen_common: return error from xen_create_ioreq_server
>>> hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure
>>> meson.build: do not set have_xen_pci_passthrough for aarch64 targets
>>>
>>> Vikram Garhwal (5):
>>> hw/i386/xen/: move xen-mapcache.c to hw/xen/
>>> hw/i386/xen: rearrange xen_hvm_init_pc
>>> hw/xen/xen-hvm-common: Use g_new and error_report
>>> hw/arm: introduce xenpvh machine
>>> meson.build: enable xenpv machine build for ARM
>>
>> Errors in CI:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/4216392008#L2381
>>
>> ../hw/i386/xen/xen-hvm.c:303:9: error: implicit declaration of function 'error_report'
>> is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>> error_report("relocate_memory %lu pages from GFN %"HWADDR_PRIx
> Thanks for notifying this. I am not sure why this particular build is failing.
> error_report() is defined in "|qemu/error-report.h" and the header should be included as
> |||it builds fine for other configs.
You removed qemu/error-report.h in
xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common
within this patch set.
r~
next prev parent reply other threads:[~2023-05-04 6:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 0:12 [PULL v3 0/10] xenpvh3-tag Stefano Stabellini
2023-05-03 0:12 ` [PULL v3 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Stefano Stabellini
2023-05-03 0:12 ` [PULL v3 02/10] hw/i386/xen: rearrange xen_hvm_init_pc Stefano Stabellini
2023-05-03 0:12 ` [PULL v3 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState Stefano Stabellini
2023-05-03 0:12 ` [PULL v3 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common Stefano Stabellini
2023-05-03 0:12 ` [PULL v3 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server Stefano Stabellini
2023-05-03 0:12 ` [PULL v3 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Stefano Stabellini
2023-05-03 0:13 ` [PULL v3 07/10] hw/xen/xen-hvm-common: Use g_new and error_report Stefano Stabellini
2023-05-03 0:13 ` [PULL v3 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets Stefano Stabellini
2023-05-03 0:13 ` [PULL v3 09/10] hw/arm: introduce xenpvh machine Stefano Stabellini
2023-05-03 0:13 ` [PULL v3 10/10] meson.build: enable xenpv machine build for ARM Stefano Stabellini
2023-05-03 7:47 ` [PULL v3 0/10] xenpvh3-tag Richard Henderson
2023-05-04 5:18 ` Vikram Garhwal
2023-05-04 6:34 ` Richard Henderson [this message]
2023-06-06 18:51 ` Garhwal, Vikram
2023-06-06 22:50 ` Richard Henderson
2023-06-06 23:12 ` Vikram Garhwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd7325e0-7db1-3b1f-7ce1-319aa58ebd1f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=vikram.garhwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).