From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C178C433E0 for ; Fri, 19 Jun 2020 13:01:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 711292080C for ; Fri, 19 Jun 2020 13:01:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 711292080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmGeb-0005de-MT for qemu-devel@archiver.kernel.org; Fri, 19 Jun 2020 09:01:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmGdK-0004iE-Ta for qemu-devel@nongnu.org; Fri, 19 Jun 2020 09:00:38 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:44209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmGdI-0000A6-Fz for qemu-devel@nongnu.org; Fri, 19 Jun 2020 09:00:38 -0400 Received: from [192.168.100.1] ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MStOy-1jJ9gU1rNG-00UMHa; Fri, 19 Jun 2020 15:00:24 +0200 Subject: Re: [PATCH v5 3/6] linux-user: Add strace support for printing argument of syscalls used for extended attributes To: Filip Bozuta , qemu-devel@nongnu.org References: <20200619123331.17387-1-filip.bozuta@syrmia.com> <20200619123331.17387-4-filip.bozuta@syrmia.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Fri, 19 Jun 2020 15:00:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200619123331.17387-4-filip.bozuta@syrmia.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:9x/j0OnSoOPqyTTFDd7bvHFr+sp6IyZNprD2rHKZ0sipAETvqGb /7ynPkvvrpn2+44DPOm5ZWGzKl8wZI7tb1J/eKal1Dz/QoZm1PukCqtzHitAyJ7quCP9lum e2+3ZPFDN9CUW7u9XH4YiJ+am2TLh39PQCYoPGn0Tk9ftsFUI5Ri9tyG5TN8GVE0iNnyckw X+cd5vT/xGBs1TG1x/zZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:0loujdjQSbQ=:61T+SwjGS4Gh7r35R/SlTy 3q5b4caEFW+zsfKwPV7656qq6DF3WaOblhRSrWzCJHrvPbMvDFNZ1ki/9wCHGiSg8M/JDFGPH 4OPrZlM/0VBd6D6IVx69w3N9RVIf1A1nep6H6SRJlLHIs2kIAgIE/Ru3nE2efLiFGKX1bS5QO WMp5V5x1YQRBiJviMcvcQvbmQOKALAhNjzjpVi42CKYDWYeA/g9IG57iUPQvEv+iP30K2XDph qeoLyXnFneVFizq2CEICZeNUGO09QWWBTUyc1nyUg7OaTxWAoDy1En4SpTp29LYw5idOy55BF nuxq/wRBn+qOfo2dWieHibOlLHQdjl4D4Tgtxc5EmV4ulvbPrYFhDedrhAUPytEnftAy2xjUN 52gNf8k/0ngr/7CiKpgO4C78QPWIEcwH82dkNdSaBYp4ptepNu8MpPJ+nvzoYXti1AZI8UbyT olNEYTNgqogEEUaTTrP/dXVKZYOOCWpqr797n2lgX9jWWIqRMtEbN/bgDw4iuu+MIPXOqAk3+ 3q8YRIhefj62C2tPPpO0AckaCeewCYsl2SgXw/TGmSJORSz8tXHzQ13nMXPVXS6qhb7QAeUY2 7tDwwJQpxReBDtf4raHvQrYP0i7EBTgM0stjTQKzaMaE751ofXajLa7AddTBV5kJJjzly+r+q +VlPeIcIvhpPeFOjUHaVH2xU+k3JVNE4EjzGnmQC9vmQ8ciawg7OxOTeIboxfLqS6oTCMZpjq MfrRg+/+iMEiggVznDmx+/OtE8lhy2TOHKn7qtUIHiOhJv8IUih48X10Op8x24Ej3b/DsX8bI QBuPbLJouemxfu+k8KF+axBLVBLM94h1Wx4J/+oyGNEEaw8PH8= Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 09:00:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: riku.voipio@iki.fi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 19/06/2020 à 14:33, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements strace argument printing functionality for following syscalls: > > *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value > > ssize_t getxattr(const char *path, const char *name, void *value, size_t size) > ssize_t lgetxattr(const char *path, const char *name, void *value, size_t size) > ssize_t fgetxattr(int fd, const char *name, void *value, size_t size) > man page: https://www.man7.org/linux/man-pages/man2/getxattr.2.html > > *listxattr, llistxattr, flistxattr - list extended attribute names > > ssize_t listxattr(const char *path, char *list, size_t size) > ssize_t llistxattr(const char *path, char *list, size_t size) > ssize_t flistxattr(int fd, char *list, size_t size) > man page: https://www.man7.org/linux/man-pages/man2/listxattr.2.html > > *removexattr, lremovexattr, fremovexattr - remove an extended attribute > > int removexattr(const char *path, const char *name) > int lremovexattr(const char *path, const char *name) > int fremovexattr(int fd, const char *name) > man page: https://www.man7.org/linux/man-pages/man2/removexattr.2.html > > Implementation notes: > > All of the syscalls have strings as argument types and thus a separate > printing function was stated in file "strace.list" for every one of them. > All of these printing functions were defined in "strace.c" using existing > printing functions for appropriate argument types: > "print_string()" - for (const char*) type > "print_pointer()" - for (char*) and (void *) type > "print_raw_param()" for (int) and (size_t) type > Syscalls "getxattr()" and "lgetxattr()" have the same number and type of > arguments and thus their print functions ("print_getxattr", "print_lgetxattr") > share a same definition. The same statement applies to syscalls "listxattr()" > and "llistxattr()". > Function "print_syscall_ret_listxattr()" was added to print the returned list > of extended attributes for syscalls "print_listxattr(), print_llistxattr() and > print_flistxattr()". > > Signed-off-by: Filip Bozuta > --- > linux-user/strace.c | 121 +++++++++++++++++++++++++++++++++++++++++ > linux-user/strace.list | 21 ++++--- > 2 files changed, 133 insertions(+), 9 deletions(-) > Reviewed-by: Laurent Vivier