From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Cédric Le Goater" <clg@kaod.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Cameron Esfahani" <dirty@apple.com>
Cc: Robert Mustacchi <rm@fingolfin.org>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Peter Maydell <peter.maydell@linaro.org>,
Cameron Esfahani via <qemu-devel@nongnu.org>,
kraxel@redhat.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v1] usb: Add read support for HCIVERSION register to XHCI
Date: Fri, 03 Apr 2020 11:18:54 +1030 [thread overview]
Message-ID: <dd8fc1f7-56d9-4d9f-96a4-0fdcafdc8f55@www.fastmail.com> (raw)
In-Reply-To: <2c04ba56-436d-354b-512e-50c9d995b702@kaod.org>
On Wed, 1 Apr 2020, at 21:53, Cédric Le Goater wrote:
> Hello,
>
> On 3/31/20 1:02 PM, Philippe Mathieu-Daudé wrote:
> > On 3/31/20 11:57 AM, Cameron Esfahani wrote:
> >> Philippe -
> >> From what I've seen, access size has nothing to do with alignment.
> >
> > Yes, I was wondering if you were using unaligned accesses.
> >
> > I *think* the correct fix is in the "memory: Support unaligned accesses on aligned-only models" patch from Andrew Jeffery:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg461247.html
>
> Here is an updated version I have been keeping since :
>
> https://github.com/legoater/qemu/commit/d57ac950c4be47a2bafd6c6a96dec2922c2ecd65
>
> which breaks qtest :
>
> microbit-test.c:307:test_nrf51_gpio: assertion failed (actual ==
> 0x01): (0 == 1)
>
> I haven't had time to look at this closely but it would be nice to get this
> patch merged.
Second this! I never had the chance to circle back and fix it up.
Andrew
next prev parent reply other threads:[~2020-04-03 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 21:44 [PATCH v1] usb: Add read support for HCIVERSION register to XHCI Cameron Esfahani via
2020-03-31 7:52 ` Philippe Mathieu-Daudé
2020-03-31 9:57 ` Cameron Esfahani via
2020-03-31 10:24 ` Cameron Esfahani via
2020-03-31 11:02 ` Philippe Mathieu-Daudé
2020-04-01 11:23 ` Cédric Le Goater
2020-04-03 0:48 ` Andrew Jeffery [this message]
2020-04-06 22:54 ` Cameron Esfahani via
2020-03-31 14:42 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd8fc1f7-56d9-4d9f-96a4-0fdcafdc8f55@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=dirty@apple.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=qemu-devel@nongnu.org \
--cc=rm@fingolfin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).