Re: [PATCH 14/24] tests/functional: Move mips tests into target-specific folders

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 5/8/25 15:56, Thomas Huth wrote:
> On 04/08/2025 10.31, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 1/8/25 17:12, Thomas Huth wrote:
>>> From: Thomas Huth <thuth@redhat.com>
>>>
>>> The tests/functional folder has become quite crowded, thus move the
>>> mips tests into a target-specific subfolder.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   MAINTAINERS                                   |  8 ++--
>>>   tests/functional/meson.build                  | 47 ++-----------------
>>>   tests/functional/mips/meson.build             | 11 +++++
>>>   .../test_malta.py}                            |  0
>>>   .../test_replay.py}                           |  0
>>>   .../test_tuxrun.py}                           |  0
>>>   tests/functional/mips64/meson.build           | 10 ++++
>>>   .../test_malta.py}                            |  2 +-
>>>   .../test_tuxrun.py}                           |  0
>>>   tests/functional/mips64el/meson.build         | 14 ++++++
>>>   .../test_fuloong2e.py}                        |  0
>>>   .../test_loongson3v.py}                       |  0
>>>   .../test_malta.py}                            |  4 +-
>>>   .../test_replay.py}                           |  0
>>>   .../test_tuxrun.py}                           |  0
>>>   tests/functional/mipsel/meson.build           | 12 +++++
>>>   .../test_malta.py}                            |  2 +-
>>>   .../test_replay.py}                           |  0
>>>   .../test_tuxrun.py}                           |  0
>>>   19 files changed, 59 insertions(+), 51 deletions(-)
>>>   create mode 100644 tests/functional/mips/meson.build
>>>   rename tests/functional/{test_mips_malta.py => mips/test_malta.py} 
>>> (100%)
>>>   rename tests/functional/{test_mips_replay.py => mips/ 
>>> test_replay.py} (100%)
>>>   rename tests/functional/{test_mips_tuxrun.py => mips/ 
>>> test_tuxrun.py} (100%)
>>>   create mode 100644 tests/functional/mips64/meson.build
>>>   rename tests/functional/{test_mips64_malta.py => mips64/ 
>>> test_malta.py} (96%)
>>>   rename tests/functional/{test_mips64_tuxrun.py => mips64/ 
>>> test_tuxrun.py} (100%)
>>>   create mode 100644 tests/functional/mips64el/meson.build
>>>   rename tests/functional/{test_mips64el_fuloong2e.py => mips64el/ 
>>> test_fuloong2e.py} (100%)
>>>   rename tests/functional/{test_mips64el_loongson3v.py => mips64el/ 
>>> test_loongson3v.py} (100%)
>>>   rename tests/functional/{test_mips64el_malta.py => mips64el/ 
>>> test_malta.py} (98%)
>>>   rename tests/functional/{test_mips64el_replay.py => mips64el/ 
>>> test_replay.py} (100%)
>>>   rename tests/functional/{test_mips64el_tuxrun.py => mips64el/ 
>>> test_tuxrun.py} (100%)
>>>   create mode 100644 tests/functional/mipsel/meson.build
>>>   rename tests/functional/{test_mipsel_malta.py => mipsel/ 
>>> test_malta.py} (98%)
>>>   rename tests/functional/{test_mipsel_replay.py => mipsel/ 
>>> test_replay.py} (100%)
>>>   mode change 100644 => 100755
>>>   rename tests/functional/{test_mipsel_tuxrun.py => mipsel/ 
>>> test_tuxrun.py} (100%)
>>
>>
>>> +subdir('mips')
>>> +subdir('mipsel')
>>> +subdir('mips64')
>>> +subdir('mips64el')
>>
>> Just one single comment here. I'd rather have a single mips/ directory
>> and keep the variants inside it, i.e.:
>>
>>    tests/functional/mips/test_mips64el_malta.py
> 
> That would make it very cumbersome to determine which qemu-system-mips* 
> binary we'd need for those tests. Currently the tests for each qemu- 
> system-xyz are simply looked up in the xyz subfolder. If we put all mips 
> targets into one folder, we'd need to add some special case logic which 
> I'd really like to avoid.
> And in case the mips targets get unified later, we still can simply move 
> the tests to one folder again, there is no hurry to do this right now 
> already.

Alright, fine then.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>