* [Qemu-devel] [PATCH] block: Ignore generated job QAPI files
@ 2018-05-31 21:24 Eric Blake
2018-05-31 21:40 ` [Qemu-devel] [Qemu-block] " Jeff Cody
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Blake @ 2018-05-31 21:24 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, kwolf, mreitz
Commit bf42508f introduced new generated files; make sure they
don't get accidentally committed from an in-tree build.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
.gitignore | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/.gitignore b/.gitignore
index 81e1f2fb0f1..9da3b3e6267 100644
--- a/.gitignore
+++ b/.gitignore
@@ -36,6 +36,7 @@
/qapi/qapi-commands-common.[ch]
/qapi/qapi-commands-crypto.[ch]
/qapi/qapi-commands-introspect.[ch]
+/qapi/qapi-commands-job.[ch]
/qapi/qapi-commands-migration.[ch]
/qapi/qapi-commands-misc.[ch]
/qapi/qapi-commands-net.[ch]
@@ -53,6 +54,7 @@
/qapi/qapi-events-common.[ch]
/qapi/qapi-events-crypto.[ch]
/qapi/qapi-events-introspect.[ch]
+/qapi/qapi-events-job.[ch]
/qapi/qapi-events-migration.[ch]
/qapi/qapi-events-misc.[ch]
/qapi/qapi-events-net.[ch]
@@ -71,6 +73,7 @@
/qapi/qapi-types-common.[ch]
/qapi/qapi-types-crypto.[ch]
/qapi/qapi-types-introspect.[ch]
+/qapi/qapi-types-job.[ch]
/qapi/qapi-types-migration.[ch]
/qapi/qapi-types-misc.[ch]
/qapi/qapi-types-net.[ch]
@@ -88,6 +91,7 @@
/qapi/qapi-visit-common.[ch]
/qapi/qapi-visit-crypto.[ch]
/qapi/qapi-visit-introspect.[ch]
+/qapi/qapi-visit-job.[ch]
/qapi/qapi-visit-migration.[ch]
/qapi/qapi-visit-misc.[ch]
/qapi/qapi-visit-net.[ch]
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: Ignore generated job QAPI files
2018-05-31 21:24 [Qemu-devel] [PATCH] block: Ignore generated job QAPI files Eric Blake
@ 2018-05-31 21:40 ` Jeff Cody
2018-06-04 11:01 ` [Qemu-devel] " Max Reitz
2018-06-07 15:09 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Cody @ 2018-05-31 21:40 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, mreitz
On Thu, May 31, 2018 at 04:24:35PM -0500, Eric Blake wrote:
> Commit bf42508f introduced new generated files; make sure they
> don't get accidentally committed from an in-tree build.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 81e1f2fb0f1..9da3b3e6267 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -36,6 +36,7 @@
> /qapi/qapi-commands-common.[ch]
> /qapi/qapi-commands-crypto.[ch]
> /qapi/qapi-commands-introspect.[ch]
> +/qapi/qapi-commands-job.[ch]
> /qapi/qapi-commands-migration.[ch]
> /qapi/qapi-commands-misc.[ch]
> /qapi/qapi-commands-net.[ch]
> @@ -53,6 +54,7 @@
> /qapi/qapi-events-common.[ch]
> /qapi/qapi-events-crypto.[ch]
> /qapi/qapi-events-introspect.[ch]
> +/qapi/qapi-events-job.[ch]
> /qapi/qapi-events-migration.[ch]
> /qapi/qapi-events-misc.[ch]
> /qapi/qapi-events-net.[ch]
> @@ -71,6 +73,7 @@
> /qapi/qapi-types-common.[ch]
> /qapi/qapi-types-crypto.[ch]
> /qapi/qapi-types-introspect.[ch]
> +/qapi/qapi-types-job.[ch]
> /qapi/qapi-types-migration.[ch]
> /qapi/qapi-types-misc.[ch]
> /qapi/qapi-types-net.[ch]
> @@ -88,6 +91,7 @@
> /qapi/qapi-visit-common.[ch]
> /qapi/qapi-visit-crypto.[ch]
> /qapi/qapi-visit-introspect.[ch]
> +/qapi/qapi-visit-job.[ch]
> /qapi/qapi-visit-migration.[ch]
> /qapi/qapi-visit-misc.[ch]
> /qapi/qapi-visit-net.[ch]
> --
> 2.14.3
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Ignore generated job QAPI files
2018-05-31 21:24 [Qemu-devel] [PATCH] block: Ignore generated job QAPI files Eric Blake
2018-05-31 21:40 ` [Qemu-devel] [Qemu-block] " Jeff Cody
@ 2018-06-04 11:01 ` Max Reitz
2018-06-07 15:09 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2 siblings, 0 replies; 4+ messages in thread
From: Max Reitz @ 2018-06-04 11:01 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-block, kwolf
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
On 2018-05-31 23:24, Eric Blake wrote:
> Commit bf42508f introduced new generated files; make sure they
> don't get accidentally committed from an in-tree build.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: Ignore generated job QAPI files
2018-05-31 21:24 [Qemu-devel] [PATCH] block: Ignore generated job QAPI files Eric Blake
2018-05-31 21:40 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-06-04 11:01 ` [Qemu-devel] " Max Reitz
@ 2018-06-07 15:09 ` Jeff Cody
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Cody @ 2018-06-07 15:09 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, kwolf, qemu-block, mreitz
On Thu, May 31, 2018 at 04:24:35PM -0500, Eric Blake wrote:
> Commit bf42508f introduced new generated files; make sure they
> don't get accidentally committed from an in-tree build.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Not sure which maintainer this ultimately goes through, but since it
references auto-generated block job related files, I'll go ahead and run it
through my repo:
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 81e1f2fb0f1..9da3b3e6267 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -36,6 +36,7 @@
> /qapi/qapi-commands-common.[ch]
> /qapi/qapi-commands-crypto.[ch]
> /qapi/qapi-commands-introspect.[ch]
> +/qapi/qapi-commands-job.[ch]
> /qapi/qapi-commands-migration.[ch]
> /qapi/qapi-commands-misc.[ch]
> /qapi/qapi-commands-net.[ch]
> @@ -53,6 +54,7 @@
> /qapi/qapi-events-common.[ch]
> /qapi/qapi-events-crypto.[ch]
> /qapi/qapi-events-introspect.[ch]
> +/qapi/qapi-events-job.[ch]
> /qapi/qapi-events-migration.[ch]
> /qapi/qapi-events-misc.[ch]
> /qapi/qapi-events-net.[ch]
> @@ -71,6 +73,7 @@
> /qapi/qapi-types-common.[ch]
> /qapi/qapi-types-crypto.[ch]
> /qapi/qapi-types-introspect.[ch]
> +/qapi/qapi-types-job.[ch]
> /qapi/qapi-types-migration.[ch]
> /qapi/qapi-types-misc.[ch]
> /qapi/qapi-types-net.[ch]
> @@ -88,6 +91,7 @@
> /qapi/qapi-visit-common.[ch]
> /qapi/qapi-visit-crypto.[ch]
> /qapi/qapi-visit-introspect.[ch]
> +/qapi/qapi-visit-job.[ch]
> /qapi/qapi-visit-migration.[ch]
> /qapi/qapi-visit-misc.[ch]
> /qapi/qapi-visit-net.[ch]
> --
> 2.14.3
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-07 15:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-31 21:24 [Qemu-devel] [PATCH] block: Ignore generated job QAPI files Eric Blake
2018-05-31 21:40 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-06-04 11:01 ` [Qemu-devel] " Max Reitz
2018-06-07 15:09 ` [Qemu-devel] [Qemu-block] " Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).