From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
Date: Thu, 16 Sep 2021 06:55:48 +0200 [thread overview]
Message-ID: <ddb8181c-2653-180f-4460-c8626a613101@redhat.com> (raw)
In-Reply-To: <9f2ea524-1718-a454-050f-af558ad380c0@redhat.com>
On 16/09/2021 06.24, Philippe Mathieu-Daudé wrote:
> On 9/16/21 12:27 AM, Paolo Bonzini wrote:
>> On 14/09/21 10:21, Daniel P. Berrangé wrote:
>>> Yes, this is needed to fix Ruby 3.
>>>
>>> I didn't propose it myself as I'm not sure if it in turn breaks people
>>> with Ruby 2.x ?
>>
>> Does it pass the GitLab CI (which uses 2.5)?
>
> Yes:
> https://gitlab.com/philmd/qemu-web/-/jobs/1594757246#L466
> Installing webrick 1.7.0
> Bundle complete! 5 Gemfile dependencies, 32 gems now installed.
The patch is also not breaking anything for me here (with Ruby 2.5.9).
Pushed now.
Thanks,
Thomas
next prev parent reply other threads:[~2021-09-16 4:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 18:29 [qemu-web PATCH] Gemfile: Add webrick bundle dependency Philippe Mathieu-Daudé
2021-09-14 5:17 ` Thomas Huth
2021-09-14 6:31 ` Philippe Mathieu-Daudé
2021-09-14 8:21 ` Daniel P. Berrangé
2021-09-15 22:27 ` Paolo Bonzini
2021-09-16 4:24 ` Philippe Mathieu-Daudé
2021-09-16 4:55 ` Thomas Huth [this message]
2021-09-16 5:03 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb8181c-2653-180f-4460-c8626a613101@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).