From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE1EC433C1 for ; Wed, 24 Mar 2021 07:22:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76320619FA for ; Wed, 24 Mar 2021 07:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76320619FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOxqi-0007C0-Fp for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 03:22:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOxpi-0006Ti-S8; Wed, 24 Mar 2021 03:21:38 -0400 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]:57705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOxpf-0006dh-Q9; Wed, 24 Mar 2021 03:21:38 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.146.221]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 020D2942C29B; Wed, 24 Mar 2021 08:21:17 +0100 (CET) Received: from kaod.org (37.59.142.101) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 08:21:17 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-101G004c136c555-75ab-491b-a1c7-460183a1137a, 90EFDD1C85C6F754CEE6F6149A82CEA72524D6DA) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Subject: Re: [PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE To: Joel Stanley , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210324070955.125941-1-joel@jms.id.au> <20210324070955.125941-4-joel@jms.id.au> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: Date: Wed, 24 Mar 2021 08:21:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210324070955.125941-4-joel@jms.id.au> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG7EX1.mxp5.local (172.16.2.61) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 0a70b190-448b-40a7-9ce6-24bf55c84cc0 X-Ovh-Tracer-Id: 16748042592242600809 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrudegjedguddtjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeejkeduueduveelgeduueegkeelffevledujeetffeivdelvdfgkeeufeduheehfeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepjhhovghlsehjmhhsrdhiugdrrghu Received-SPF: pass client-ip=178.32.125.2; envelope-from=clg@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , Thomas Huth , qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/24/21 8:09 AM, Joel Stanley wrote: > This adds a test for the Aspeed Hash and Crypto (HACE) engine. It tests > the currently implemented behavior of the hash functionality. > > The tests are similar, but are cut/pasted instead of broken out into a > common function so the assert machinery produces useful output when a > test fails. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Thomas, Can we keep your Acked-by ? Thanks, C. > --- > v3: Write test without libqtest-single.h > v4: Run tests on all aspeed machines > --- > tests/qtest/aspeed_hace-test.c | 313 +++++++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > tests/qtest/meson.build | 3 + > 3 files changed, 317 insertions(+) > create mode 100644 tests/qtest/aspeed_hace-test.c > > diff --git a/tests/qtest/aspeed_hace-test.c b/tests/qtest/aspeed_hace-test.c > new file mode 100644 > index 000000000000..2b624b6b099b > --- /dev/null > +++ b/tests/qtest/aspeed_hace-test.c > @@ -0,0 +1,313 @@ > +/* > + * QTest testcase for the ASPEED Hash and Crypto Engine > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + * Copyright 2021 IBM Corp. > + */ > + > +#include "qemu/osdep.h" > + > +#include "libqos/libqtest.h" > +#include "qemu-common.h" > +#include "qemu/bitops.h" > + > +#define HACE_CMD 0x10 > +#define HACE_SHA_BE_EN BIT(3) > +#define HACE_MD5_LE_EN BIT(2) > +#define HACE_ALGO_MD5 0 > +#define HACE_ALGO_SHA1 BIT(5) > +#define HACE_ALGO_SHA224 BIT(6) > +#define HACE_ALGO_SHA256 (BIT(4) | BIT(6)) > +#define HACE_ALGO_SHA512 (BIT(5) | BIT(6)) > +#define HACE_ALGO_SHA384 (BIT(5) | BIT(6) | BIT(10)) > +#define HACE_SG_EN BIT(18) > + > +#define HACE_STS 0x1c > +#define HACE_RSA_ISR BIT(13) > +#define HACE_CRYPTO_ISR BIT(12) > +#define HACE_HASH_ISR BIT(9) > +#define HACE_RSA_BUSY BIT(2) > +#define HACE_CRYPTO_BUSY BIT(1) > +#define HACE_HASH_BUSY BIT(0) > +#define HACE_HASH_SRC 0x20 > +#define HACE_HASH_DIGEST 0x24 > +#define HACE_HASH_KEY_BUFF 0x28 > +#define HACE_HASH_DATA_LEN 0x2c > +#define HACE_HASH_CMD 0x30 > + > +/* > + * Test vector is the ascii "abc" > + * > + * Expected results were generated using command line utitiles: > + * > + * echo -n -e 'abc' | dd of=/tmp/test > + * for hash in sha512sum sha256sum md5sum; do $hash /tmp/test; done > + * > + */ > +static const uint8_t test_vector[] = {0x61, 0x62, 0x63}; > + > +static const uint8_t test_result_sha512[] = { > + 0xdd, 0xaf, 0x35, 0xa1, 0x93, 0x61, 0x7a, 0xba, 0xcc, 0x41, 0x73, 0x49, > + 0xae, 0x20, 0x41, 0x31, 0x12, 0xe6, 0xfa, 0x4e, 0x89, 0xa9, 0x7e, 0xa2, > + 0x0a, 0x9e, 0xee, 0xe6, 0x4b, 0x55, 0xd3, 0x9a, 0x21, 0x92, 0x99, 0x2a, > + 0x27, 0x4f, 0xc1, 0xa8, 0x36, 0xba, 0x3c, 0x23, 0xa3, 0xfe, 0xeb, 0xbd, > + 0x45, 0x4d, 0x44, 0x23, 0x64, 0x3c, 0xe8, 0x0e, 0x2a, 0x9a, 0xc9, 0x4f, > + 0xa5, 0x4c, 0xa4, 0x9f}; > + > +static const uint8_t test_result_sha256[] = { > + 0xba, 0x78, 0x16, 0xbf, 0x8f, 0x01, 0xcf, 0xea, 0x41, 0x41, 0x40, 0xde, > + 0x5d, 0xae, 0x22, 0x23, 0xb0, 0x03, 0x61, 0xa3, 0x96, 0x17, 0x7a, 0x9c, > + 0xb4, 0x10, 0xff, 0x61, 0xf2, 0x00, 0x15, 0xad}; > + > +static const uint8_t test_result_md5[] = { > + 0x90, 0x01, 0x50, 0x98, 0x3c, 0xd2, 0x4f, 0xb0, 0xd6, 0x96, 0x3f, 0x7d, > + 0x28, 0xe1, 0x7f, 0x72}; > + > + > +static void write_regs(QTestState *s, uint32_t base, uint32_t src, > + uint32_t length, uint32_t out, uint32_t method) > +{ > + qtest_writel(s, base + HACE_HASH_SRC, src); > + qtest_writel(s, base + HACE_HASH_DIGEST, out); > + qtest_writel(s, base + HACE_HASH_DATA_LEN, length); > + qtest_writel(s, base + HACE_HASH_CMD, HACE_SHA_BE_EN | method); > +} > + > +static void test_md5(const char *machine, const uint32_t base, > + const uint32_t src_addr) > + > +{ > + QTestState *s = qtest_init(machine); > + > + uint32_t digest_addr = src_addr + 0x01000000; > + uint8_t digest[16] = {0}; > + > + /* Check engine is idle, no busy or irq bits set */ > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0); > + > + /* Write test vector into memory */ > + qtest_memwrite(s, src_addr, test_vector, sizeof(test_vector)); > + > + write_regs(s, base, src_addr, sizeof(test_vector), digest_addr, HACE_ALGO_MD5); > + > + /* Check hash IRQ status is asserted */ > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0x00000200); > + > + /* Clear IRQ status and check status is deasserted */ > + qtest_writel(s, base + HACE_STS, 0x00000200); > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0); > + > + /* Read computed digest from memory */ > + qtest_memread(s, digest_addr, digest, sizeof(digest)); > + > + /* Check result of computation */ > + g_assert_cmpmem(digest, sizeof(digest), > + test_result_md5, sizeof(digest)); > +} > + > +static void test_sha256(const char *machine, const uint32_t base, > + const uint32_t src_addr) > +{ > + QTestState *s = qtest_init(machine); > + > + const uint32_t digest_addr = src_addr + 0x1000000; > + uint8_t digest[32] = {0}; > + > + /* Check engine is idle, no busy or irq bits set */ > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0); > + > + /* Write test vector into memory */ > + qtest_memwrite(s, src_addr, test_vector, sizeof(test_vector)); > + > + write_regs(s, base, src_addr, sizeof(test_vector), digest_addr, HACE_ALGO_SHA256); > + > + /* Check hash IRQ status is asserted */ > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0x00000200); > + > + /* Clear IRQ status and check status is deasserted */ > + qtest_writel(s, base + HACE_STS, 0x00000200); > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0); > + > + /* Read computed digest from memory */ > + qtest_memread(s, digest_addr, digest, sizeof(digest)); > + > + /* Check result of computation */ > + g_assert_cmpmem(digest, sizeof(digest), > + test_result_sha256, sizeof(digest)); > +} > + > +static void test_sha512(const char *machine, const uint32_t base, > + const uint32_t src_addr) > +{ > + QTestState *s = qtest_init(machine); > + > + const uint32_t digest_addr = src_addr + 0x1000000; > + uint8_t digest[64] = {0}; > + > + /* Check engine is idle, no busy or irq bits set */ > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0); > + > + /* Write test vector into memory */ > + qtest_memwrite(s, src_addr, test_vector, sizeof(test_vector)); > + > + write_regs(s, base, src_addr, sizeof(test_vector), digest_addr, HACE_ALGO_SHA512); > + > + /* Check hash IRQ status is asserted */ > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0x00000200); > + > + /* Clear IRQ status and check status is deasserted */ > + qtest_writel(s, base + HACE_STS, 0x00000200); > + g_assert_cmphex(qtest_readl(s, base + HACE_STS), ==, 0); > + > + /* Read computed digest from memory */ > + qtest_memread(s, digest_addr, digest, sizeof(digest)); > + > + /* Check result of computation */ > + g_assert_cmpmem(digest, sizeof(digest), > + test_result_sha512, sizeof(digest)); > +} > + > +struct masks { > + uint32_t src; > + uint32_t dest; > + uint32_t len; > +}; > + > +static const struct masks ast2600_masks = { > + .src = 0x7fffffff, > + .dest = 0x7ffffff8, > + .len = 0x0fffffff, > +}; > + > +static const struct masks ast2500_masks = { > + .src = 0x3fffffff, > + .dest = 0x3ffffff8, > + .len = 0x0fffffff, > +}; > + > +static const struct masks ast2400_masks = { > + .src = 0x0fffffff, > + .dest = 0x0ffffff8, > + .len = 0x0fffffff, > +}; > + > +static void test_addresses(const char *machine, const uint32_t base, > + const struct masks *expected) > +{ > + QTestState *s = qtest_init(machine); > + > + /* > + * Check command mode is zero, meaning engine is in direct access mode, > + * as this affects the masking behavior of the HASH_SRC register. > + */ > + g_assert_cmphex(qtest_readl(s, base + HACE_CMD), ==, 0); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_SRC), ==, 0); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DIGEST), ==, 0); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DATA_LEN), ==, 0); > + > + > + /* Check that the address masking is correct */ > + qtest_writel(s, base + HACE_HASH_SRC, 0xffffffff); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_SRC), ==, expected->src); > + > + qtest_writel(s, base + HACE_HASH_DIGEST, 0xffffffff); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DIGEST), ==, expected->dest); > + > + qtest_writel(s, base + HACE_HASH_DATA_LEN, 0xffffffff); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DATA_LEN), ==, expected->len); > + > + /* Reset to zero */ > + qtest_writel(s, base + HACE_HASH_SRC, 0); > + qtest_writel(s, base + HACE_HASH_DIGEST, 0); > + qtest_writel(s, base + HACE_HASH_DATA_LEN, 0); > + > + /* Check that all bits are now zero */ > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_SRC), ==, 0); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DIGEST), ==, 0); > + g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DATA_LEN), ==, 0); > +} > + > +/* ast2600 */ > +static void test_md5_ast2600(void) > +{ > + test_md5("-machine ast2600-evb", 0x1e6d0000, 0x80000000); > +} > + > +static void test_sha256_ast2600(void) > +{ > + test_sha256("-machine ast2600-evb", 0x1e6d0000, 0x80000000); > +} > + > +static void test_sha512_ast2600(void) > +{ > + test_sha512("-machine ast2600-evb", 0x1e6d0000, 0x80000000); > +} > + > +static void test_addresses_ast2600(void) > +{ > + test_addresses("-machine ast2600-evb", 0x1e6d0000, &ast2600_masks); > +} > + > +/* ast2500 */ > +static void test_md5_ast2500(void) > +{ > + test_md5("-machine ast2500-evb", 0x1e6e3000, 0x80000000); > +} > + > +static void test_sha256_ast2500(void) > +{ > + test_sha256("-machine ast2500-evb", 0x1e6e3000, 0x80000000); > +} > + > +static void test_sha512_ast2500(void) > +{ > + test_sha512("-machine ast2500-evb", 0x1e6e3000, 0x80000000); > +} > + > +static void test_addresses_ast2500(void) > +{ > + test_addresses("-machine ast2500-evb", 0x1e6e3000, &ast2500_masks); > +} > + > +/* ast2400 */ > +static void test_md5_ast2400(void) > +{ > + test_md5("-machine palmetto-bmc", 0x1e6e3000, 0x40000000); > +} > + > +static void test_sha256_ast2400(void) > +{ > + test_sha256("-machine palmetto-bmc", 0x1e6e3000, 0x40000000); > +} > + > +static void test_sha512_ast2400(void) > +{ > + test_sha512("-machine palmetto-bmc", 0x1e6e3000, 0x40000000); > +} > + > +static void test_addresses_ast2400(void) > +{ > + test_addresses("-machine palmetto-bmc", 0x1e6e3000, &ast2400_masks); > +} > + > +int main(int argc, char **argv) > +{ > + g_test_init(&argc, &argv, NULL); > + > + qtest_add_func("ast2600/hace/addresses", test_addresses_ast2600); > + qtest_add_func("ast2600/hace/sha512", test_sha512_ast2600); > + qtest_add_func("ast2600/hace/sha256", test_sha256_ast2600); > + qtest_add_func("ast2600/hace/md5", test_md5_ast2600); > + > + qtest_add_func("ast2500/hace/addresses", test_addresses_ast2500); > + qtest_add_func("ast2500/hace/sha512", test_sha512_ast2500); > + qtest_add_func("ast2500/hace/sha256", test_sha256_ast2500); > + qtest_add_func("ast2500/hace/md5", test_md5_ast2500); > + > + qtest_add_func("ast2400/hace/addresses", test_addresses_ast2400); > + qtest_add_func("ast2400/hace/sha512", test_sha512_ast2400); > + qtest_add_func("ast2400/hace/sha256", test_sha256_ast2400); > + qtest_add_func("ast2400/hace/md5", test_md5_ast2400); > + > + return g_test_run(); > +} > diff --git a/MAINTAINERS b/MAINTAINERS > index 9147e9a429a0..62f44456d809 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1026,6 +1026,7 @@ F: include/hw/misc/pca9552*.h > F: hw/net/ftgmac100.c > F: include/hw/net/ftgmac100.h > F: docs/system/arm/aspeed.rst > +F: tests/qtest/*aspeed* > > NRF51 > M: Joel Stanley > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 902cfef7cb2f..84b3219c15c6 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -163,12 +163,15 @@ qtests_npcm7xx = \ > 'npcm7xx_timer-test', > 'npcm7xx_watchdog_timer-test'] + \ > (slirp.found() ? ['npcm7xx_emc-test'] : []) > +qtests_aspeed = \ > + ['aspeed_hace-test'] > qtests_arm = \ > (config_all_devices.has_key('CONFIG_MPS2') ? ['sse-timer-test'] : []) + \ > (config_all_devices.has_key('CONFIG_CMSDK_APB_DUALTIMER') ? ['cmsdk-apb-dualtimer-test'] : []) + \ > (config_all_devices.has_key('CONFIG_CMSDK_APB_TIMER') ? ['cmsdk-apb-timer-test'] : []) + \ > (config_all_devices.has_key('CONFIG_CMSDK_APB_WATCHDOG') ? ['cmsdk-apb-watchdog-test'] : []) + \ > (config_all_devices.has_key('CONFIG_PFLASH_CFI02') ? ['pflash-cfi02-test'] : []) + \ > + (config_all_devices.has_key('CONFIG_ASPEED_SOC') ? qtests_aspeed : []) + \ > (config_all_devices.has_key('CONFIG_NPCM7XX') ? qtests_npcm7xx : []) + \ > ['arm-cpu-features', > 'microbit-test', >