Re: [PATCH for-8.2 1/6] vfio/migration: Move from STOP_COPY to STOP in vfio_save_cleanup()

["Cédric Le Goater" <clg@redhat.com>]

On 7/31/23 08:32, Avihai Horon wrote:
> 
> On 30/07/2023 19:25, Cédric Le Goater wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 7/16/23 10:15, Avihai Horon wrote:
>>> Changing the device state from STOP_COPY to STOP can take time as the
>>> device may need to free resources and do other operations as part of the
>>> transition. Currently, this is done in vfio_save_complete_precopy() and
>>> therefore it is counted in the migration downtime.
>>>
>>> To avoid this, change the device state from STOP_COPY to STOP in
>>> vfio_save_cleanup(), which is called after migration has completed and
>>> thus is not part of migration downtime.
>>>
>>> Signed-off-by: Avihai Horon <avihaih@nvidia.com>
>>
>> Have you tried this series with vGPUs ? If so, are there any improvement
>> to report ?
>>
> Not with a vGPU.
> But I tried it with a ConnectX-7 VF and I could see up to 6% downtime improvement.
> I mentioned this in the cover letter.
> Do you want to mention it also in the commit message?

This is not necessary.

Thanks,

C.