From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>, Anton Johansson <anjo@rev.ng>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH-for-9.1 5/8] target/microblaze: Restrict 64-bit 'res_addr' to system emulation
Date: Tue, 19 Mar 2024 19:17:13 +0100 [thread overview]
Message-ID: <dde20cea-e4cb-484c-b282-8808cbe9b09b@linaro.org> (raw)
In-Reply-To: <Zfm88Hit3Kni1f_4@toto>
On 19/3/24 17:27, Edgar E. Iglesias wrote:
> On Tue, Mar 19, 2024 at 07:28:52AM +0100, Philippe Mathieu-Daudé wrote:
>> 'res_addr' is only used in system emulation, where we have
>> TARGET_LONG_BITS = 64, so we can directly use the native
>> uint64_t type instead of target_ulong.
>
>
> Hi Philippe,
>
> This breaks linux-user, lwx and swx are valid user-mode insns.
Now I see I missed cpu_res_addr. Thanks for the quick review!
>
> Best regards,
> Edgar
>
>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> target/microblaze/cpu.h | 10 +++++-----
>> target/microblaze/cpu.c | 2 ++
>> target/microblaze/machine.c | 2 +-
>> target/microblaze/translate.c | 9 +++++++--
>> 4 files changed, 15 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2024-03-19 18:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 6:28 [PATCH-for-9.1 0/8] target/microblaze: Sprint housekeeping Philippe Mathieu-Daudé
2024-03-19 6:28 ` [PATCH-for-9.1 1/8] target/microblaze: Use correct string format in do_unaligned_access() Philippe Mathieu-Daudé
2024-03-19 15:52 ` Anton Johansson via
2024-03-19 16:29 ` Edgar E. Iglesias
2024-03-19 6:28 ` [PATCH-for-9.1 2/8] target/microblaze: Use hwaddr/vaddr in cpu_get_phys_page_attrs_debug() Philippe Mathieu-Daudé
2024-03-19 15:53 ` Anton Johansson via
2024-03-19 16:29 ` Edgar E. Iglesias
2024-03-19 6:28 ` [PATCH-for-9.1 3/8] target/microblaze: Widen vaddr in mmu_translate() Philippe Mathieu-Daudé
2024-03-19 15:54 ` Anton Johansson via
2024-03-19 21:00 ` Edgar E. Iglesias
2024-03-19 6:28 ` [PATCH-for-9.1 4/8] target/microblaze: Use 32-bit destination in gen_goto_tb() Philippe Mathieu-Daudé
2024-03-19 15:57 ` Anton Johansson via
2024-03-19 21:01 ` Edgar E. Iglesias
2024-03-19 6:28 ` [PATCH-for-9.1 5/8] target/microblaze: Restrict 64-bit 'res_addr' to system emulation Philippe Mathieu-Daudé
2024-03-19 16:01 ` Anton Johansson via
2024-03-19 16:27 ` Edgar E. Iglesias
2024-03-19 18:17 ` Philippe Mathieu-Daudé [this message]
2024-03-19 6:28 ` [PATCH-for-9.1 6/8] target/microblaze: Rename helper.c -> sys_helper.c Philippe Mathieu-Daudé
2024-03-19 16:02 ` Anton Johansson via
2024-03-19 21:01 ` Edgar E. Iglesias
2024-03-19 6:28 ` [PATCH-for-9.1 7/8] target/microblaze: Move MMU helpers to sys_helper.c Philippe Mathieu-Daudé
2024-03-19 16:03 ` Anton Johansson via
2024-03-19 21:01 ` Edgar E. Iglesias
2024-03-19 6:28 ` [RFC PATCH-for-9.1 8/8] target/microblaze: Widen $ear to 64-bit Philippe Mathieu-Daudé
2024-03-19 16:21 ` Anton Johansson via
2024-03-19 21:07 ` Edgar E. Iglesias
2024-03-19 6:30 ` [PATCH-for-9.1 0/8] target/microblaze: Sprint housekeeping Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde20cea-e4cb-484c-b282-8808cbe9b09b@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=anjo@rev.ng \
--cc=edgar.iglesias@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).