From: Paolo Bonzini <pbonzini@redhat.com>
To: Bernhard Beschow <shentey@gmail.com>, Olaf Hering <olaf@aepfle.de>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Lev Kujawski" <lkujaw@member.fsf.org>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register
Date: Tue, 4 Jul 2023 08:38:33 +0200 [thread overview]
Message-ID: <dded4d33-d64f-9369-0742-a57a1e173153@redhat.com> (raw)
In-Reply-To: <93902CB6-7A6E-49E5-A55F-432C6B4BC00F@gmail.com>
On 7/3/23 22:33, Bernhard Beschow wrote:
> Paolo, Peter: Should we switch to pci_device_reset() in
> pci_xen_ide_unplug()? Or is device_cold_reset() supposed to do
> everything?
device_cold_reset() does not reset state that is part of the bus, so I
think it's consistent that it doesn't call pci_do_device_reset().
I agree that calling pci_device_reset() would be a better match for
pci_xen_ide_unplug().
Paolo
next prev parent reply other threads:[~2023-07-04 6:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 17:46 [PATCH v2] hw/ide/piix: properly initialize the BMIBA register Olaf Hering
2023-07-02 22:18 ` Bernhard Beschow
2023-07-03 7:59 ` Olaf Hering
2023-07-03 20:33 ` Bernhard Beschow
2023-07-04 6:38 ` Paolo Bonzini [this message]
2023-07-05 10:01 ` Olaf Hering
2023-07-05 21:52 ` Bernhard Beschow
2023-07-11 9:11 ` Olaf Hering
2023-07-11 19:06 ` Bernhard Beschow
2023-07-17 8:46 ` Bernhard Beschow
2023-07-17 8:52 ` Olaf Hering
2023-07-17 11:03 ` Olaf Hering
2023-07-17 18:55 ` Bernhard Beschow
2023-07-11 19:04 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dded4d33-d64f-9369-0742-a57a1e173153@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lkujaw@member.fsf.org \
--cc=olaf@aepfle.de \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).