From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36899C4338F for ; Tue, 10 Aug 2021 05:20:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B7AD60551 for ; Tue, 10 Aug 2021 05:20:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B7AD60551 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDKBw-0003BM-K2 for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 01:20:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKBB-0001V1-3S; Tue, 10 Aug 2021 01:19:57 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:45003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDKB9-0004qL-8c; Tue, 10 Aug 2021 01:19:56 -0400 Received: by mail-wm1-x333.google.com with SMTP id d131-20020a1c1d890000b02902516717f562so1633062wmd.3; Mon, 09 Aug 2021 22:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W+Ek/FQM1vnO/sLlgjELhxHO6P+5qop+j3W5LXxENUE=; b=dyZv1VR2yymH8YTar4/0N1ssWsBC/jl9xRNA6Uk1DBeWMhyfMnqbpUIWlHoa0y+lsW d4PUoDd5kZ5AwU1/dAo9tpqgIkkNYnUjFKzvmd5pBpDC665nDxOPhmR3Lh/lfWVqWnlN NlbDban/6Ly2fe2K966J/qBBl3hN4u7BgsZUQzvkW8nG7mWx5ZN2RTj2otzVj9DcHDb+ L6uMsMwkQdWSdk/nuSbxoZV+cv1MLvSOElDqmowngNcOYD8mO+WEsofW/DESFN2faViX d7ZxkRrnrcaxEvMJS2g9dGnyG3+TCL0YLZOsTjuzNdn8RajIXfl9AAv0KoJ3V+SdCRH+ RxWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W+Ek/FQM1vnO/sLlgjELhxHO6P+5qop+j3W5LXxENUE=; b=h6G/tOtABb6PpXshdRXVFGXR2iCH31hTiaaqipcyzqjBowpOZJnyS0rtpM1k3jpEfu 1RgC+2XZ1V8Wx1uZhvw7DCAAC9M/Rb1uSDnRXVQvMForttpxLo5KtD7BrlmOqIBL6lIv v73LsFmiRG/tbjXI6+m67UGtixW40SpME6LUzh2U4NeiR8JPU1tOUapELqWnEf/lj4vt cSICysahOJbyFvNRYF6AWLFvoYSg0yD7CY7+mSAcS6tozIcMMQ3DZgUz5y1sIQeZ8bbM G5MLwROgWtlPvTb7VQIdbR6TrcTQzJDwf/vpZpFCvhkMRQF8Y1t/B6HWE2kyqxW7/Tzt At1A== X-Gm-Message-State: AOAM5304t/SM5apZlLLoMhxyEKGT1ZjELkCRbQ+o7qtvn0hnXR+Tsykd db/3j0U9hQHY67dKSTOZR1A= X-Google-Smtp-Source: ABdhPJzA6fS0cFQRdLDILkRKbyviP5Pw+Z8xqxqtyAp48kr1EJc78VmXjAlf8kZAq9q9Vq0PRm2o4g== X-Received: by 2002:a05:600c:3b15:: with SMTP id m21mr20474630wms.99.1628572793124; Mon, 09 Aug 2021 22:19:53 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id t1sm1485328wma.25.2021.08.09.22.19.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 22:19:52 -0700 (PDT) Subject: Re: [PATCH] fsl-imx6ul: add SAI1/2/3 and ASRC as unimplemented devices To: Guenter Roeck , Peter Maydell References: <20210810041059.553384-1-linux@roeck-us.net> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 10 Aug 2021 07:19:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810041059.553384-1-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Jean-Christophe Dubois Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Guenter, On 8/10/21 6:10 AM, Guenter Roeck wrote: > Define SAI1/2/3 and ASRC as unimplemented devices to avoid random > Linux kernel crashes. Relevant dmesg output could be useful. > Signed-off-by: Guenter Roeck > --- > hw/arm/fsl-imx6ul.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c > index e0128d7316..48b60eb3ce 100644 > --- a/hw/arm/fsl-imx6ul.c > +++ b/hw/arm/fsl-imx6ul.c > @@ -534,6 +534,13 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) > */ > create_unimplemented_device("sdma", FSL_IMX6UL_SDMA_ADDR, 0x4000); > > + /* > + * SAI "Audio SSI (Synchronous Serial Interface)" > + */ > + create_unimplemented_device("sai1", FSL_IMX6UL_SAI1_ADDR, 0x4000); > + create_unimplemented_device("sai2", FSL_IMX6UL_SAI2_ADDR, 0x4000); > + create_unimplemented_device("sai3", FSL_IMX6UL_SAI3_ADDR, 0x4000); Hmm I see these named SSI[123] in the datasheet. The Synchronous Serial Interface (SSI) is a full-duplex serial port that allows communication with external devices using a variety of serial protocols. The SSI supports a wide variety of protocols (SSI normal, SSI network, I2S, and AC-97), bit depths (up to 24 bits per word), and clock/frame sync options. The three SSIs may support three audio streams (possibly at different sample rates) simultaneously. SSI1, SSI2 and SSI3 are located on the Shared Peripheral Bus. Since the SDMA can directly access SSI1...SSI3 (being on the Shared Peripheral Bus), they can be used for high-bandwidth data transfers in order to optimize bus bandwidth consumption. Since QEMU models SPI devices in hw/ssi/, having the devices named "sai*" is OK. > + > /* > * PWM > */ > @@ -542,6 +549,11 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp) > create_unimplemented_device("pwm3", FSL_IMX6UL_PWM3_ADDR, 0x4000); > create_unimplemented_device("pwm4", FSL_IMX6UL_PWM4_ADDR, 0x4000); > > + /* > + * ASRC "Audio ASRC (asynchronous sample rate converter)" Preferably updating the descriptions: Reviewed-by: Philippe Mathieu-Daudé > + */ > + create_unimplemented_device("asrc", FSL_IMX6UL_ASRC_ADDR, 0x4000); > + > /* > * CAN > */ >