From: Jing Liu <liujbjl@linux.vnet.ibm.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087
Date: Mon, 24 Jul 2017 14:44:13 +0800 [thread overview]
Message-ID: <ddf57b6c-42b2-0ec1-7d53-71d5266727fe@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170721034730.25612-4-crosa@redhat.com>
Hi Cleber,
On 2017/7/21 上午11:47, Cleber Rosa wrote:
> One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO.
>
> As a PoC/RFC, this goes the easy route and skips the test as a whole
> when that feature is missing. Other approaches include splitting
> the test and adding extra filtering.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/qemu-iotests/087 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087
> index f8e4903..a2fb7de 100755
> --- a/tests/qemu-iotests/087
> +++ b/tests/qemu-iotests/087
> @@ -34,6 +34,7 @@ status=1 # failure is the default!
> _supported_fmt qcow2
> _supported_proto file
> _supported_os Linux
> +_require_feature CONFIG_LINUX_AIO
I tested that CONFIG_NETTLE_KDF is also a necessary for 087.
+_require_feature CONFIG_NETTLE_KDF
>
> function do_run_qemu()
> {
next prev parent reply other threads:[~2017-07-24 6:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 3:47 [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip Cleber Rosa
2017-07-21 3:47 ` [Qemu-devel] [PATCH 1/3] scripts: introduce buildconf.py Cleber Rosa
2017-07-21 14:00 ` Eric Blake
2017-07-21 14:07 ` Cleber Rosa
2017-07-21 3:47 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: add _require_feature() function Cleber Rosa
2017-07-21 3:47 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087 Cleber Rosa
2017-07-24 6:44 ` Jing Liu [this message]
2017-07-25 15:45 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-25 15:48 ` Daniel P. Berrange
2017-07-26 8:55 ` Jing Liu
2017-07-26 9:49 ` Daniel P. Berrange
2017-07-21 4:39 ` [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip no-reply
2017-07-21 12:33 ` Stefan Hajnoczi
2017-07-21 13:49 ` Cleber Rosa
2017-08-08 8:01 ` Markus Armbruster
2017-07-21 14:01 ` Daniel P. Berrange
2017-07-21 14:21 ` Cleber Rosa
2017-07-25 15:49 ` Stefan Hajnoczi
2017-07-25 16:16 ` Cleber Rosa
2017-07-25 16:24 ` Daniel P. Berrange
2017-07-25 16:47 ` Cleber Rosa
2017-07-26 17:58 ` Stefan Hajnoczi
2017-07-26 18:24 ` Cleber Rosa
2017-07-27 13:41 ` Stefan Hajnoczi
2017-08-08 8:06 ` Markus Armbruster
2017-08-08 12:44 ` Stefan Hajnoczi
2017-08-08 14:52 ` Markus Armbruster
2017-08-09 10:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddf57b6c-42b2-0ec1-7d53-71d5266727fe@linux.vnet.ibm.com \
--to=liujbjl@linux.vnet.ibm.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).