From: Jason Wang <jasowang@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>, qemu-devel@nongnu.org
Cc: Harpreet Singh Anand <hanand@xilinx.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>, Cindy Lu <lulu@redhat.com>,
alvaro.karsz@solid-run.com, Zhu Lingshan <lingshan.zhu@intel.com>,
Lei Yang <leiyang@redhat.com>,
Liuxiangdong <liuxiangdong5@huawei.com>,
Shannon Nelson <snelson@pensando.io>,
Parav Pandit <parav@mellanox.com>,
Gautam Dawar <gdawar@xilinx.com>, Eli Cohen <eli@mellanox.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
longpeng2@huawei.com, virtualization@lists.linux-foundation.org,
Stefano Garzarella <sgarzare@redhat.com>,
si-wei.liu@oracle.com
Subject: Re: [PATCH v2 09/13] vdpa net: block migration if the device has CVQ
Date: Wed, 22 Feb 2023 12:00:48 +0800 [thread overview]
Message-ID: <de141eaa-6cc4-e942-9fff-de4dcee8625f@redhat.com> (raw)
In-Reply-To: <20230208094253.702672-10-eperezma@redhat.com>
在 2023/2/8 17:42, Eugenio Pérez 写道:
> Devices with CVQ needs to migrate state beyond vq state. Leaving this
> to future series.
I may miss something but what is missed to support CVQ/MQ?
Thanks
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> net/vhost-vdpa.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index bca13f97fd..309861e56c 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -955,11 +955,17 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
> }
>
> if (has_cvq) {
> + VhostVDPAState *s;
> +
> nc = net_vhost_vdpa_init(peer, TYPE_VHOST_VDPA, name,
> vdpa_device_fd, i, 1, false,
> opts->x_svq, iova_range);
> if (!nc)
> goto err;
> +
> + s = DO_UPCAST(VhostVDPAState, nc, nc);
> + error_setg(&s->vhost_vdpa.dev->migration_blocker,
> + "net vdpa cannot migrate with MQ feature");
> }
>
> return 0;
next prev parent reply other threads:[~2023-02-22 4:01 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:42 [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration Eugenio Pérez
2023-02-08 9:42 ` [PATCH v2 01/13] vdpa net: move iova tree creation from init to start Eugenio Pérez
2023-02-13 6:50 ` Si-Wei Liu
2023-02-13 11:14 ` Eugenio Perez Martin
2023-02-14 1:45 ` Si-Wei Liu
2023-02-14 19:07 ` Eugenio Perez Martin
2023-02-16 2:14 ` Si-Wei Liu
2023-02-16 7:35 ` Eugenio Perez Martin
2023-02-17 7:38 ` Si-Wei Liu
2023-02-17 13:55 ` Eugenio Perez Martin
2023-02-08 9:42 ` [PATCH v2 02/13] vdpa: Negotiate _F_SUSPEND feature Eugenio Pérez
2023-02-08 9:42 ` [PATCH v2 03/13] vdpa: add vhost_vdpa_suspend Eugenio Pérez
2023-02-21 5:27 ` Jason Wang
2023-02-21 5:33 ` Jason Wang
2023-02-21 7:05 ` Eugenio Perez Martin
2023-02-08 9:42 ` [PATCH v2 04/13] vdpa: move vhost reset after get vring base Eugenio Pérez
2023-02-21 5:36 ` Jason Wang
2023-02-21 7:07 ` Eugenio Perez Martin
2023-02-22 3:43 ` Jason Wang
2023-02-08 9:42 ` [PATCH v2 05/13] vdpa: rewind at get_base, not set_base Eugenio Pérez
2023-02-21 5:40 ` Jason Wang
2023-02-08 9:42 ` [PATCH v2 06/13] vdpa net: allow VHOST_F_LOG_ALL Eugenio Pérez
2023-02-08 9:42 ` [PATCH v2 07/13] vdpa: add vdpa net migration state notifier Eugenio Pérez
2023-02-13 6:50 ` Si-Wei Liu
2023-02-13 15:51 ` Eugenio Perez Martin
2023-02-22 3:55 ` Jason Wang
2023-02-22 7:23 ` Eugenio Perez Martin
2023-02-08 9:42 ` [PATCH v2 08/13] vdpa: disable RAM block discard only for the first device Eugenio Pérez
2023-02-08 9:42 ` [PATCH v2 09/13] vdpa net: block migration if the device has CVQ Eugenio Pérez
2023-02-13 6:50 ` Si-Wei Liu
2023-02-14 18:06 ` Eugenio Perez Martin
2023-02-22 4:00 ` Jason Wang [this message]
2023-02-22 7:28 ` Eugenio Perez Martin
2023-02-23 2:41 ` Jason Wang
2023-02-08 9:42 ` [PATCH v2 10/13] vdpa: block migration if device has unsupported features Eugenio Pérez
2023-02-08 9:42 ` [PATCH v2 11/13] vdpa: block migration if dev does not have _F_SUSPEND Eugenio Pérez
2023-02-22 4:05 ` Jason Wang
2023-02-22 14:25 ` Eugenio Perez Martin
2023-02-23 2:38 ` Jason Wang
2023-02-23 11:06 ` Eugenio Perez Martin
2023-02-24 3:16 ` Jason Wang
2023-02-08 9:42 ` [PATCH v2 12/13] vdpa: block migration if SVQ does not admit a feature Eugenio Pérez
2023-02-08 9:42 ` [PATCH v2 13/13] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices Eugenio Pérez
2023-02-22 4:07 ` Jason Wang
2023-02-08 10:29 ` [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration Alvaro Karsz
2023-02-09 14:38 ` Lei Yang
2023-02-10 12:57 ` Gautam Dawar
2023-02-15 18:40 ` Eugenio Perez Martin
2023-02-16 13:50 ` Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de141eaa-6cc4-e942-9fff-de4dcee8625f@redhat.com \
--to=jasowang@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=arei.gonglei@huawei.com \
--cc=eli@mellanox.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=leiyang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=snelson@pensando.io \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).