qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"John Snow" <jsnow@redhat.com>, "Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc
Date: Mon, 6 Mar 2023 12:36:25 +0100	[thread overview]
Message-ID: <de1a7397-210e-1c63-e5bc-7b241e6a07e5@redhat.com> (raw)
In-Reply-To: <ZAW7DcpRDcGF2VQx@redhat.com>

On 3/6/23 11:06, Daniel P. Berrangé wrote:
>> This offers developpers a simpler way to build QEMU with missing system
>> dependencies (ex, libslirp in my case), but also simplify the fallback build
>> definition of dtc/libfdt.
> Do we actually need this facility though ? We've already determined
> that every platform we need has libslirp now, and IIUC Thomas determined
> recently that dtc is also available everywhere we need it to be.

libvfio-user can use Meson subprojects instead of submodules, too; and 
with Pip support probably coming in 8.1, we can remove the meson 
submodule.  Then, the only mostly-mandatory submodule would be 
keycodemapdb; SLOF requires a cross-compiler and the pre-built is binary 
is shipped binary, while softfloat/testfloat are test only and maybe 
could even be embedded.  So there is a path towards getting rid of 
submodules at least for the main QEMU build process.

Also, Windows installer builds could benefit from having wrapdb support 
for the mandatory dependencies in Windows (pixman, zlib, glib, possibly 
SDL).

Since they are unintrusive and easy to revert, I think we could include 
patches 1-3 as experimental in 8.0, though I'm happy to oblige if people 
disagree (and only include patch 1).

Paolo



  parent reply	other threads:[~2023-03-06 11:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 13:18 [PATCH 0/4] Add meson wrap fallback for slirp & dtc marcandre.lureau
2023-03-02 13:18 ` [PATCH 1/4] mtest2make.py: teach suite name that are just "PROJECT" marcandre.lureau
2023-03-02 13:18 ` [PATCH 2/4] build-sys: prevent meson from downloading wrapped subprojects marcandre.lureau
2023-03-02 13:18 ` [PATCH 3/4] build-sys: add slirp.wrap marcandre.lureau
2023-03-02 13:18 ` [PATCH 4/4] build-sys: replace dtc submodule with dtc.wrap marcandre.lureau
2023-03-06 10:06 ` [PATCH 0/4] Add meson wrap fallback for slirp & dtc Daniel P. Berrangé
2023-03-06 10:17   ` Peter Maydell
2023-03-06 10:25     ` Marc-André Lureau
2023-03-06 10:19   ` Marc-André Lureau
2023-03-06 10:32     ` Daniel P. Berrangé
2023-03-06 10:41       ` Marc-André Lureau
2023-03-06 11:36   ` Paolo Bonzini [this message]
2023-03-07 11:19     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de1a7397-210e-1c63-e5bc-7b241e6a07e5@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).