From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Zixi Chen <zixchen@redhat.com>
Subject: Re: [PATCH] target/i386: SEV: fix mismatch in vcek-disabled property name
Date: Fri, 2 Aug 2024 10:29:30 +0200 [thread overview]
Message-ID: <de1d3350-152f-9424-bc03-05bf216739be@amd.com> (raw)
In-Reply-To: <20240801234345.355447-1-pbonzini@redhat.com>
On 8/2/2024 1:43 AM, Paolo Bonzini wrote:
> The vcek-disabled property of the sev-snp-guest object is misspelled
> vcek-required (which I suppose would use the opposite polarity) in
> the call to object_class_property_add_bool(). Fix it.
>
> Reported-by: Zixi Chen <zixchen@redhat.com>
> Cc: Pankaj Gupta <pankaj.gupta@amd.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/i386/sev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index a1157c0ede6..a0d271f8986 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -2422,7 +2422,7 @@ sev_snp_guest_class_init(ObjectClass *oc, void *data)
> object_class_property_add_bool(oc, "author-key-enabled",
> sev_snp_guest_get_author_key_enabled,
> sev_snp_guest_set_author_key_enabled);
> - object_class_property_add_bool(oc, "vcek-required",
> + object_class_property_add_bool(oc, "vcek-disabled",
> sev_snp_guest_get_vcek_disabled,
> sev_snp_guest_set_vcek_disabled);
> object_class_property_add_str(oc, "host-data",
Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
prev parent reply other threads:[~2024-08-02 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 23:43 [PATCH] target/i386: SEV: fix mismatch in vcek-disabled property name Paolo Bonzini
2024-08-02 8:29 ` Gupta, Pankaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1d3350-152f-9424-bc03-05bf216739be@amd.com \
--to=pankaj.gupta@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zixchen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).