* [PATCH] target/i386: SEV: fix mismatch in vcek-disabled property name
@ 2024-08-01 23:43 Paolo Bonzini
2024-08-02 8:29 ` Gupta, Pankaj
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2024-08-01 23:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Zixi Chen, Pankaj Gupta
The vcek-disabled property of the sev-snp-guest object is misspelled
vcek-required (which I suppose would use the opposite polarity) in
the call to object_class_property_add_bool(). Fix it.
Reported-by: Zixi Chen <zixchen@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/sev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/sev.c b/target/i386/sev.c
index a1157c0ede6..a0d271f8986 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -2422,7 +2422,7 @@ sev_snp_guest_class_init(ObjectClass *oc, void *data)
object_class_property_add_bool(oc, "author-key-enabled",
sev_snp_guest_get_author_key_enabled,
sev_snp_guest_set_author_key_enabled);
- object_class_property_add_bool(oc, "vcek-required",
+ object_class_property_add_bool(oc, "vcek-disabled",
sev_snp_guest_get_vcek_disabled,
sev_snp_guest_set_vcek_disabled);
object_class_property_add_str(oc, "host-data",
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/i386: SEV: fix mismatch in vcek-disabled property name
2024-08-01 23:43 [PATCH] target/i386: SEV: fix mismatch in vcek-disabled property name Paolo Bonzini
@ 2024-08-02 8:29 ` Gupta, Pankaj
0 siblings, 0 replies; 2+ messages in thread
From: Gupta, Pankaj @ 2024-08-02 8:29 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Zixi Chen
On 8/2/2024 1:43 AM, Paolo Bonzini wrote:
> The vcek-disabled property of the sev-snp-guest object is misspelled
> vcek-required (which I suppose would use the opposite polarity) in
> the call to object_class_property_add_bool(). Fix it.
>
> Reported-by: Zixi Chen <zixchen@redhat.com>
> Cc: Pankaj Gupta <pankaj.gupta@amd.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/i386/sev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index a1157c0ede6..a0d271f8986 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -2422,7 +2422,7 @@ sev_snp_guest_class_init(ObjectClass *oc, void *data)
> object_class_property_add_bool(oc, "author-key-enabled",
> sev_snp_guest_get_author_key_enabled,
> sev_snp_guest_set_author_key_enabled);
> - object_class_property_add_bool(oc, "vcek-required",
> + object_class_property_add_bool(oc, "vcek-disabled",
> sev_snp_guest_get_vcek_disabled,
> sev_snp_guest_set_vcek_disabled);
> object_class_property_add_str(oc, "host-data",
Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 23:43 [PATCH] target/i386: SEV: fix mismatch in vcek-disabled property name Paolo Bonzini
2024-08-02 8:29 ` Gupta, Pankaj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).