From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E42C433FF for ; Mon, 5 Aug 2019 15:57:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ACEE208C3 for ; Mon, 5 Aug 2019 15:57:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ACEE208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hufMt-0006YX-Rl for qemu-devel@archiver.kernel.org; Mon, 05 Aug 2019 11:57:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57549) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hufMU-0005wi-Ag for qemu-devel@nongnu.org; Mon, 05 Aug 2019 11:57:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hufMT-0000wT-9h for qemu-devel@nongnu.org; Mon, 05 Aug 2019 11:57:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52434) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hufMQ-0000uI-R9; Mon, 05 Aug 2019 11:57:23 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98E6E83F4C; Mon, 5 Aug 2019 15:57:21 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77D285DA21; Mon, 5 Aug 2019 15:57:16 +0000 (UTC) To: qemu-block@nongnu.org References: <20190805153308.2657-1-mreitz@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Mon, 5 Aug 2019 17:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190805153308.2657-1-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pZe5fUb4h3HIVa9BW1mK1ZKCCaPPjCkJj" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 05 Aug 2019 15:57:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3] mirror: Only mirror granularity-aligned chunks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pZe5fUb4h3HIVa9BW1mK1ZKCCaPPjCkJj Content-Type: multipart/mixed; boundary="hBfJiAmWqGnjeQGm0cDsqi8qscA622eKE"; protected-headers="v1" From: Max Reitz To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy , John Snow , Kevin Wolf , qemu-stable@nongnu.org Message-ID: Subject: Re: [PATCH v3] mirror: Only mirror granularity-aligned chunks References: <20190805153308.2657-1-mreitz@redhat.com> In-Reply-To: <20190805153308.2657-1-mreitz@redhat.com> --hBfJiAmWqGnjeQGm0cDsqi8qscA622eKE Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 05.08.19 17:33, Max Reitz wrote: > In write-blocking mode, all writes to the top node directly go to the > target. We must only mirror chunks of data that are aligned to the > job's granularity, because that is how the dirty bitmap works. > Therefore, the request alignment for writes must be the job's > granularity (in write-blocking mode). >=20 > Unfortunately, this forces all reads and writes to have the same > granularity (we only need this alignment for writes to the target, not > the source), but that is something to be fixed another time. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Max Reitz > --- > v3: Handle bdrv_refresh_limits() errors [Vladimir] > --- > block/mirror.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Thanks for the review, I=E2=80=99m taking the silence around =E2=80=9Cfix= unaligned reset=E2=80=9D as a sign to take this patch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max --hBfJiAmWqGnjeQGm0cDsqi8qscA622eKE-- --pZe5fUb4h3HIVa9BW1mK1ZKCCaPPjCkJj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl1IUdoACgkQ9AfbAGHV z0CfHAf8D0g6HcEhQcuqAN+iEjgMO4MpzMNgBM4xtakf442YNudOTGm4kN8mb4tx TaiWqmVUhXtCe94TjMzxkzg6PjL3hifK9NzC/MB0ptbv/PJlJn0rbRCl+W/Z+PIL Y0t/YU497IqXFxWpoVcf1eX71UV+M8yRdxQGg4Yd4BSxENvYoIC6Dk6wC76dWX7B OI5Il/DS4qk1G9+fSqgbuKCEs/D454lHDatyE2L5dhOU7vHXhbZrDqRl7xdAKLhT ZOlM3m/GSee/gsEIYCWRyA1coGtCbKbEbFAlUAobgaAgZ0k1xy3eCoy+FhwOE3/F dmbFeCmC4tnwod0b5Fgo5nlk28RQxA== =N/RZ -----END PGP SIGNATURE----- --pZe5fUb4h3HIVa9BW1mK1ZKCCaPPjCkJj--