qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'
@ 2025-03-16 21:02 Niek Linnenbank
  2025-03-17  6:45 ` Thomas Huth
  2025-03-17 13:08 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 3+ messages in thread
From: Niek Linnenbank @ 2025-03-16 21:02 UTC (permalink / raw)
  To: qemu-devel; +Cc: thuth, berrange, stefanha, Niek Linnenbank

The test class in this file contains all functional test cases
for testing the Orange Pi PC board. It should be given a name
matching the Qemu machine it covers.

This commit sets the test class name to 'OrangePiMachine'.

Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
---
 tests/functional/test_arm_orangepi.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/functional/test_arm_orangepi.py b/tests/functional/test_arm_orangepi.py
index 18ee50216b..28919391e5 100755
--- a/tests/functional/test_arm_orangepi.py
+++ b/tests/functional/test_arm_orangepi.py
@@ -14,7 +14,7 @@
 from qemu_test.utils import image_pow2ceil_expand
 
 
-class BananaPiMachine(LinuxKernelTest):
+class OrangePiMachine(LinuxKernelTest):
 
     ASSET_DEB = Asset(
         ('https://apt.armbian.com/pool/main/l/linux-6.6.16/'
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'
  2025-03-16 21:02 [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine' Niek Linnenbank
@ 2025-03-17  6:45 ` Thomas Huth
  2025-03-17 13:08 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2025-03-17  6:45 UTC (permalink / raw)
  To: Niek Linnenbank, qemu-devel; +Cc: berrange, stefanha

On 16/03/2025 22.02, Niek Linnenbank wrote:
> The test class in this file contains all functional test cases
> for testing the Orange Pi PC board. It should be given a name
> matching the Qemu machine it covers.
> 
> This commit sets the test class name to 'OrangePiMachine'.
> 
> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> ---
>   tests/functional/test_arm_orangepi.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/functional/test_arm_orangepi.py b/tests/functional/test_arm_orangepi.py
> index 18ee50216b..28919391e5 100755
> --- a/tests/functional/test_arm_orangepi.py
> +++ b/tests/functional/test_arm_orangepi.py
> @@ -14,7 +14,7 @@
>   from qemu_test.utils import image_pow2ceil_expand
>   
>   
> -class BananaPiMachine(LinuxKernelTest):
> +class OrangePiMachine(LinuxKernelTest):

D'oh, copy-n-paste bug ...

Fixes: 380f7268b7b ("tests/functional: Convert the OrangePi tests to the 
functional framework")

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'
  2025-03-16 21:02 [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine' Niek Linnenbank
  2025-03-17  6:45 ` Thomas Huth
@ 2025-03-17 13:08 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-17 13:08 UTC (permalink / raw)
  To: Niek Linnenbank, qemu-devel; +Cc: thuth, berrange, stefanha

On 16/3/25 22:02, Niek Linnenbank wrote:
> The test class in this file contains all functional test cases
> for testing the Orange Pi PC board. It should be given a name
> matching the Qemu machine it covers.
> 
> This commit sets the test class name to 'OrangePiMachine'.
> 
> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> ---
>   tests/functional/test_arm_orangepi.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-03-17 13:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-16 21:02 [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine' Niek Linnenbank
2025-03-17  6:45 ` Thomas Huth
2025-03-17 13:08 ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).