From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>
Cc: "Greg Kurz" <groug@kaod.org>,
"Michael Roth" <michael.roth@amd.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Warner Losh" <imp@bsdimp.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Markus Armbruster" <armbru@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Kyle Evans" <kevans@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Eric Blake" <eblake@redhat.com>,
libvir-list@redhat.com, "Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH v4 10/10] accel/tcg: include cs_base in our hash calculations
Date: Tue, 23 May 2023 16:05:27 -0700 [thread overview]
Message-ID: <de43b8bf-e7ba-072b-1c9c-48e0b5c5aa1a@linaro.org> (raw)
In-Reply-To: <20230523125000.3674739-11-alex.bennee@linaro.org>
On 5/23/23 05:50, Alex Bennée wrote:
> static inline uint32_t qemu_xxhash5(uint64_t ab, uint64_t cd, uint32_t e)
> {
> - return qemu_xxhash7(ab, cd, e, 0, 0);
> + return qemu_xxhash8(ab, cd, e, 0, 0);
> }
>
> static inline uint32_t qemu_xxhash6(uint64_t ab, uint64_t cd, uint32_t e,
> uint32_t f)
> {
> - return qemu_xxhash7(ab, cd, e, f, 0);
> + return qemu_xxhash8(ab, cd, e, f, 0);
> +}
The last two arguments are 32 bit. Better as
qemu_xxhash8(ab, cd, 0, e, f);
r~
prev parent reply other threads:[~2023-05-23 23:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 12:49 [PATCH v4 00/10] tracing: remove dynamic vcpu state Alex Bennée
2023-05-23 12:49 ` [PATCH v4 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-05-24 9:23 ` Philippe Mathieu-Daudé
2023-05-23 12:49 ` [PATCH v4 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-05-24 9:24 ` Philippe Mathieu-Daudé
2023-05-23 12:49 ` [PATCH v4 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-05-23 12:49 ` [PATCH v4 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-05-23 12:49 ` [PATCH v4 05/10] qapi: make the vcpu parameters deprecated for 8.1 Alex Bennée
2023-05-24 9:17 ` Philippe Mathieu-Daudé
2023-05-23 12:49 ` [PATCH v4 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-05-23 12:49 ` [PATCH v4 07/10] trace: remove control-vcpu.h Alex Bennée
2023-05-23 12:49 ` [PATCH v4 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-05-23 12:49 ` [PATCH v4 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-05-23 12:50 ` [PATCH v4 10/10] accel/tcg: include cs_base in our hash calculations Alex Bennée
2023-05-23 23:05 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de43b8bf-e7ba-072b-1c9c-48e0b5c5aa1a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=libvir-list@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).