From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com
Subject: Re: [PATCH] target/i386: Fix decode of cr8
Date: Thu, 3 Jun 2021 18:03:08 +0200 [thread overview]
Message-ID: <de489310-d793-bd08-27ab-02932735d29e@redhat.com> (raw)
In-Reply-To: <20210602035511.96834-1-richard.henderson@linaro.org>
On 02/06/21 05:55, Richard Henderson wrote:
> A recent cleanup did not recognize that there are two ways
> to encode cr8: one via the LOCK and the other via REX.
>
> Fixes: 7eff2e7c
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/380
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/i386/tcg/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index 834186bcae..a7f5c0c8f2 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -8091,6 +8091,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
> case 2:
> case 3:
> case 4:
> + case 8:
> break;
> default:
> goto unknown_op;
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-06-03 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 3:55 [PATCH] target/i386: Fix decode of cr8 Richard Henderson
2021-06-03 16:03 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de489310-d793-bd08-27ab-02932735d29e@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).