Re: [PATCH qemu v2 1/3] hw/s390x: add CPI identifiers to QOM

[Nina Schoetterl-Glausch <nsg@linux.ibm.com>]

On Thu, 2025-03-06 at 15:06 +0000, Daniel P. Berrangé wrote:
> BTW, your email client is possibly mis-configured - your mail
> came through with "From: shalini <shalini@imap.linux.ibm.com>"
> and attempting to reply to that gets an error saying that
> 'imap.linux.ibm.com' does not exist.
> 
> On Thu, Mar 06, 2025 at 02:55:27PM +0100, shalini wrote:
> > On 2025-03-05 17:06, Daniel P. Berrangé wrote:
> > > On Mon, Feb 24, 2025 at 01:04:47PM +0100, Shalini Chellathurai Saroja
> > > wrote:
> > > > Add Control-Program Identification (CPI) to the QEMU Object
> > > > Model (QOM). The CPI identifiers provide information about
> > > > the guest operating system. The CPI identifiers are:
> > > > system type, system name, system level and sysplex name.
> > > > 
> > > > The system type provides the OS type of the guest (e.g. LINUX).
> > > > The system name provides the name of the guest (e.g. TESTVM).
> > > > The system level provides the distribution and kernel version
> > > > of the guest OS (e.g. 0x50e00).
> > > > The sysplex name provides the sysplex name of the guest
> > > > (e.g. SYSPLEX).
> > > > 
> > > > Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
> > > > ---
> > > >  hw/s390x/s390-virtio-ccw.c         | 29 +++++++++++++++++++++++++++++
> > > >  include/hw/s390x/s390-virtio-ccw.h |  8 ++++++++
> > > >  qapi/machine.json                  | 24 ++++++++++++++++++++++++
> > > >  3 files changed, 61 insertions(+)

[...]
> 
> > > > +# @system-name: system name of Linux instance
> > > 
> > > What is a system name ?  Is that a hostname, or is that something
> > > else ?
> > > 
> > 
> > Yes, it is the hostname of the guest virtual machine.

Is it? Seems to me it it just a user configurable name of the system.
It's empty on the two LPARs I checked.

> 
> Lets rename it to 'system-hostname' to be unambiguous.

In any case "system name" is the established name for this value on s390x.
> 
> 
> With regards,
> Daniel

-- 
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294