From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C322ECAAD3 for ; Mon, 5 Sep 2022 12:02:49 +0000 (UTC) Received: from localhost ([::1]:54152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVAoM-0002jl-59 for qemu-devel@archiver.kernel.org; Mon, 05 Sep 2022 08:02:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVAVv-000887-IT for qemu-devel@nongnu.org; Mon, 05 Sep 2022 07:43:40 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:36502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVAVt-0003PF-GG for qemu-devel@nongnu.org; Mon, 05 Sep 2022 07:43:38 -0400 Received: by mail-wm1-x335.google.com with SMTP id v7-20020a1cac07000000b003a6062a4f81so7640389wme.1 for ; Mon, 05 Sep 2022 04:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=aAd82yseCjuEpwTDjcKkoWtPeyHa4Bx0pV8Upb13f2k=; b=WKsK32OwOc7KrJf0HgOiWvXJ1hsfDZDvCjQcm/t7hX+py6wMKdXuuHH7M172Y+6hrN HqatYJIObRz/6wAXBPq6weo8daalxvlVtZA2OLsjZskv1fIJMwsFL/TDTTApxftqVmd0 Os9YCJbt1OvbUTU03+ymdppHHgG70nBaHTGv0ItgjcJjKLRO25XEPooxMmLFPgAwNx67 a1FHdPGm452bzodlZrcZlQkgbecgzB6ex6yZUkjlbHPZ0EAXvM7W9kU/MYoAXfxyhzTv IqmV8Im6XW+FSg7Nc4Q7Ejo2fIqavamifgwyJVBY/eqRe8mQSXtUP56CGwXYGHKzNdSs YbfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=aAd82yseCjuEpwTDjcKkoWtPeyHa4Bx0pV8Upb13f2k=; b=lmYmTHgqg5gV+xJdTdt9cbHHrtGfcAwgVxwDaWt+H5/9XbDZ7XuS9LxxIyi6yw197y mdy426pVusv7qcNtPREeRvmw8mgt/xiQKMiVEKTmT20ymrWle0raVa5E9Qf5aCDv6nr4 3TaQ3emNTu4fxsTlkqXjhVZZ2V3AAp2UyNXfstmFC0gUSpDQBq5+2ykhPA8gMgNfaGl3 AzGLHSsbKW2XssUpImHUug2cZZPqy6NLXFgM5GoMdmqKUarAKOaHNCp/1bu8dCWvdmyS 2V1MyACeo5HP1C0qUnyw2VCQ2TVkZlFJuMLtkiyzrhm4xJ2JTg9Qsf/WRC6Ocwo+ois4 JOIg== X-Gm-Message-State: ACgBeo22mg15i+4NEoggJufrKb85B/FI9gWiXaoixVlC28k+fB+Gj0X6 BoAB847goaxf+8TprvudYXcPXQ== X-Google-Smtp-Source: AA6agR4E7QLyV5acjucH0hDzuKL8jdtRtgSeHTG3Yw66C2hF6xHRftShokqGN7xOMXx7Yh6z9InnPw== X-Received: by 2002:a05:600c:4f4f:b0:3a5:a530:4fd7 with SMTP id m15-20020a05600c4f4f00b003a5a5304fd7mr10716020wmq.36.1662378215836; Mon, 05 Sep 2022 04:43:35 -0700 (PDT) Received: from ?IPV6:2a02:8084:a5c0:5a80:f2bf:c5c3:8866:995c? ([2a02:8084:a5c0:5a80:f2bf:c5c3:8866:995c]) by smtp.gmail.com with ESMTPSA id w1-20020a05600018c100b00224f7c1328dsm8618983wrq.67.2022.09.05.04.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 04:43:34 -0700 (PDT) Message-ID: Date: Mon, 5 Sep 2022 12:43:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 14/20] disas/nanomips: Remove function overloading Content-Language: en-US To: Milica Lazarevic , thuth@redhat.com Cc: qemu-devel@nongnu.org, cfontana@suse.de, berrange@redhat.com, pbonzini@redhat.com, vince.delvecchio@mediatek.com, peter.maydell@linaro.org, djordje.todorovic@syrmia.com, mips32r2@gmail.com, dragan.mladjenovic@syrmia.com References: <20220905095522.66941-1-milica.lazarevic@syrmia.com> <20220905095522.66941-15-milica.lazarevic@syrmia.com> From: Richard Henderson In-Reply-To: <20220905095522.66941-15-milica.lazarevic@syrmia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.716, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/5/22 10:55, Milica Lazarevic wrote: > -static uint64 copy(uint64 d) > +static uint64 copy_ui(uint64 d) > { > return d; > } > > > -static int64 copy(int64 d) > +static int64 copy_i(int64 d) > { > return d; > } These functions can surely just be removed. > -static char *IMMEDIATE(uint64 value) > +static char *IMMEDIATE_UI(uint64 value) > { > return img_format("0x%" PRIx64, value); > } > > > -static char *IMMEDIATE(int64 value) > +static char *IMMEDIATE_I(int64 value) > { > return img_format("%" PRId64, value); > } And these would be removed by the previous conversion to direct use of printf values by the individual instructions. r~