From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ADDEC4332F for ; Sun, 18 Dec 2022 22:23:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p723s-0002f2-PZ; Sun, 18 Dec 2022 17:23:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p723r-0002eD-3s for qemu-devel@nongnu.org; Sun, 18 Dec 2022 17:23:11 -0500 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p723p-0006LT-FT for qemu-devel@nongnu.org; Sun, 18 Dec 2022 17:23:10 -0500 Received: by mail-ej1-x635.google.com with SMTP id m18so17653684eji.5 for ; Sun, 18 Dec 2022 14:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oU1vIsXfzsQ8HZcqwzN7T/MAXsE1HSu+cMUHvbTZ7TM=; b=ujBFWKn7HAh7fMF4KxKCydBEEwGAgs0VK6utmSn3Oy5ZIXs9Li2xWF6tSCZA1zfi7f Cp7TllXkvQD/Yt2ltV/xny0K/gTf28WWWktW/3NGakGwmfQEIEos4HRbkYDmt5lyX9tG GyEWcCZQUC0W+Ogm2cwu8TK6p4QLP/kjAsIFRKY3qqONQ0tFdNaOS5o/7bE5+X/1WzQ6 pcsUVJtvBi0pDKuhre1Jhp4bAHAfC7e/CVyKxFZa4DLKOBYLvd7Um0/ahon4/ipN/RxS TicQnYcZT34FpMccFltEbsqWEO8tfzN1tvFuOI+5gVCU0D8gMiWlxJ7YMFAQp+4mWFqH 9OZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oU1vIsXfzsQ8HZcqwzN7T/MAXsE1HSu+cMUHvbTZ7TM=; b=OFHJH9EpEAPkgBF6t2M6BJWfHOukb6ekdwXUgZk3NrbhGFqp/gkUsDVPiRMwR9O1FU UzLxF8vx6lqD+zGPgl60aYVakG5U1yr70TB7hfkExaUljY405NRKcLg6+lP7sOJDABrE 96CrBfwTjY9un9ARElCOa0MJIbXspZ+/H1bTpUJVFeXFTohbXBuTcUJUASmrNF7tNmor Ckv1Ja1UibaJ/adynKXEIISXlo8ir/t6fabDc0tUOxIe40XIneHnp0PSjymVeyVG03dp tabTONil7QJOGwZk5Y13s+EKg2raZcDkcKNcCu4ZptYMGU+LGExVzBThbcOY8I0xeYhy yOAA== X-Gm-Message-State: AFqh2krZhhfgOJ4U+Djpkj11PzNzUKDL0SYYndVyoEz7mhYBr0HPO4nb o+ipEGAE4TW4Kuw+DcS0SxS4jA== X-Google-Smtp-Source: AMrXdXuG8QkvIh0fDS6vqLJnKHEKrG0Wvune4Hka5OTHF67qoKyUkGaWutK6edGVZBaFjWHdVE4Jlw== X-Received: by 2002:a17:907:a705:b0:7c1:6b46:a722 with SMTP id vw5-20020a170907a70500b007c16b46a722mr3726665ejc.56.1671402187543; Sun, 18 Dec 2022 14:23:07 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id sb25-20020a170906edd900b007ad2da5668csm3588489ejb.112.2022.12.18.14.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Dec 2022 14:23:07 -0800 (PST) Message-ID: Date: Sun, 18 Dec 2022 23:23:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 4/7] hw/misc: Allwinner AXP-209 Emulation Content-Language: en-US To: Strahinja Jankovic Cc: Peter Maydell , Beniamino Galvani , Niek Linnenbank , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20221218211918.3592-1-strahinja.p.jankovic@gmail.com> <20221218211918.3592-5-strahinja.p.jankovic@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=philmd@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 18/12/22 23:12, Strahinja Jankovic wrote: > Hi, > > On Sun, Dec 18, 2022 at 11:07 PM Philippe Mathieu-Daudé > wrote: >> >> On 18/12/22 22:19, Strahinja Jankovic wrote: >>> This patch adds minimal support for AXP-209 PMU. >>> Most important is chip ID since U-Boot SPL expects version 0x1. Besides >>> the chip ID register, reset values for two more registers used by A10 >>> U-Boot SPL are covered. >>> >>> Signed-off-by: Strahinja Jankovic >>> --- >>> hw/arm/Kconfig | 1 + >>> hw/misc/Kconfig | 4 + >>> hw/misc/allwinner-axp-209.c | 238 ++++++++++++++++++++++++++++++++++++ >>> hw/misc/meson.build | 1 + >>> hw/misc/trace-events | 5 + >>> 5 files changed, 249 insertions(+) >>> create mode 100644 hw/misc/allwinner-axp-209.c >> >> >>> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig >>> index 052fb54310..3855d937fd 100644 >>> --- a/hw/misc/Kconfig >>> +++ b/hw/misc/Kconfig >>> @@ -180,4 +180,8 @@ config ALLWINNER_A10_CCM >>> config ALLWINNER_A10_DRAMC >>> bool >>> >>> +config ALLWINNER_AXP_209 >> >> This controller is not specific to AllWinner. It can be plugged on any >> i2c bus. Please rename it AXP209_PMU. Otherwise LGTM! > > Do you mean only in Kconfig, or everywhere (file name, function names, > etc.)? Thanks. Keeping the file / functions names with 'allwinner' would give the false idea this is AllWinner specific; rather confusing isn't it? Besides it is not part of the SoC, this is an external component sitting on the bus. So "everywhere". Also, the "select ALLWINNER_AXP_209/AXP209_PMU" line in hw/arm/Kconfig belongs to the next patch "hw/arm: Add AXP-209 to Cubieboard". Regards, Phil.