From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXBbz-0004x0-PQ for qemu-devel@nongnu.org; Tue, 09 Aug 2016 14:18:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXBbw-0007x9-9W for qemu-devel@nongnu.org; Tue, 09 Aug 2016 14:18:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXBbw-0007ww-3N for qemu-devel@nongnu.org; Tue, 09 Aug 2016 14:18:44 -0400 References: From: John Snow Message-ID: Date: Tue, 9 Aug 2016 14:18:42 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya , QEMU Developers On 08/09/2016 01:16 PM, Ashijeet Acharya wrote: > Hi again, > I am still waiting for some guidance...Can I please get some help with = this? > > Also.. I tried hotplugging an AHCI adapter but got the following error: > Bus 'ahci.0' does not support hotplugging > > Steps I followed: > > 1. launch vm with ahci enabled > 2. (qemu) drive_add 0 file=3Dtest.qcow2,cache=3Dnone,if=3Dnone,id=3Ddis= k2,format=3Dqcow2 > OK > 3. (qemu) device_add ide-hd,bus=3Dahci.0,id=3Dahci-disk,drive=3Ddisk2 > Bus 'ahci.0' does not support hotplugging > > What am I doing wrong? > > Thanks > Ashijeet > I think you are confusing hotplugging the AHCI adapter with hotplugging=20 an IDE drive into an AHCI adapter. IDE/ATA/PATA (A rose by any other name...) drives do not support=20 hotplugging (hence "Bus 'ahci.0' does not support hotplugging"). SATA drives do in theory, but it hasn't been implemented yet. That's probably a little more involved than a Bite Sized Task, but it's=20 something that I'd be willing to review if you embarked upon such a task. > On Sat, Aug 6, 2016 at 11:21 PM, Ashijeet Acharya > wrote: >> Hi, >> >> I was working on a patch regarding a device lifecycle bitesize task >> and I wanted to clear my queries about what the task is exactly. >> >> Do I need to create a new function ahci_unrealize() in the >> hw/ide/ahci.c file which calls for qemu_del_vm_change_state_handler() >> to free the handler at the time of ahci hot unplug. >> Sounds about right. grep around for other instances of=20 qemu_del_vm_change_state_handler and try to code by example. >> Please tell me if I am on the right path and correct me if I am wrong. >> >> Thanks >> Ashijeet --=20 =E2=80=94js