qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Nick Bowler <nbowler@draconx.ca>, qemu-devel@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [PATCH 6/8] target/sparc: Fix VIS fpmerge input registers.
Date: Thu, 28 Sep 2023 14:35:07 -0700	[thread overview]
Message-ID: <de8992b1-9f7c-b6ae-aaf3-af267674f71b@linaro.org> (raw)
In-Reply-To: <20230925050545.30912-7-nbowler@draconx.ca>

On 9/24/23 01:03, Nick Bowler wrote:
>                   case 0x04b: /* VIS I fpmerge */
>                       CHECK_FPU_FEATURE(dc, VIS1);
> -                    gen_ne_fop_DDD(dc, rd, rs1, rs2, gen_helper_fpmerge);
> +                    cpu_src1_32 = gen_load_fpr_F(dc, rs1);
> +                    cpu_src2_32 = gen_load_fpr_F(dc, rs2);
> +                    cpu_dst_64 = gen_dest_fpr_D(dc, rd);
> +                    gen_helper_fpmerge(cpu_dst_64, cpu_src1_32, cpu_src2_32);
> +                    gen_store_fpr_D(dc, rd, cpu_dst_64);
>                       break;

Use gen_ne_fop_DFF.


r~


  reply	other threads:[~2023-09-28 21:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  5:03 [PATCH 0/8] SPARC VIS fixes Nick Bowler
2023-09-25  5:03 ` [PATCH 1/8] target/sparc: Fix VIS fmul8x16 input register Nick Bowler
2023-09-28 21:29   ` Richard Henderson
2023-09-25  5:03 ` [PATCH 2/8] target/sparc: Fix VIS fmul8x16au instruction Nick Bowler
2023-09-28 21:32   ` Richard Henderson
2023-09-29  0:41     ` Nick Bowler
2023-09-29  1:04       ` Richard Henderson
2023-09-25  5:03 ` [PATCH 3/8] target/sparc: Fix VIS fmul8x16al instruction Nick Bowler
2023-09-28 21:32   ` Richard Henderson
2023-09-25  5:03 ` [PATCH 4/8] target/sparc: Fix VIS fmuld8sux16 instruction Nick Bowler
2023-09-28 21:33   ` Richard Henderson
2023-09-25  5:03 ` [PATCH 5/8] target/sparc: Fix VIS fmuld8ulx16 instruction Nick Bowler
2023-09-28 21:34   ` Richard Henderson
2023-09-25  5:03 ` [PATCH 6/8] target/sparc: Fix VIS fpmerge input registers Nick Bowler
2023-09-28 21:35   ` Richard Henderson [this message]
2023-09-29  0:32     ` Nick Bowler
2023-09-25  5:03 ` [PATCH 7/8] target/sparc: Fix VIS fexpand input register Nick Bowler
2023-09-28 21:36   ` Richard Henderson
2023-09-25  5:03 ` [PATCH 8/8] target/sparc: Fix VIS subtraction instructions Nick Bowler
2023-09-28 21:40   ` Richard Henderson
2023-09-29  0:31     ` Nick Bowler
2023-09-28 20:05 ` [PATCH 0/8] SPARC VIS fixes Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8992b1-9f7c-b6ae-aaf3-af267674f71b@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=atar4qemu@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=nbowler@draconx.ca \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).