From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/5] net.h: Add description fields for qdev properites
Date: Mon, 31 May 2010 18:11:29 +0530 [thread overview]
Message-ID: <dea337d424950963a04d39c3d8953b66451b3889.1275309375.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1275309375.git.amit.shah@redhat.com>
In-Reply-To: <cover.1275309375.git.amit.shah@redhat.com>
This results in an output like:
$ ./x86_64-softmmu/qemu-system-x86_64 -device virtio-net-pci,?
...
virtio-net-pci.mac=macaddr, The MAC address for the NIC.
virtio-net-pci.vlan=vlan, The VLAN to associate the NIC with.
virtio-net-pci.netdev=netdev, The peer net device to associate with this virtual NIC.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
net.h | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/net.h b/net.h
index 0e9cc5d..9ffd4d0 100644
--- a/net.h
+++ b/net.h
@@ -21,9 +21,12 @@ typedef struct NICConf {
} NICConf;
#define DEFINE_NIC_PROPERTIES(_state, _conf) \
- DEFINE_PROP_MACADDR("mac", _state, _conf.macaddr, ""), \
- DEFINE_PROP_VLAN("vlan", _state, _conf.vlan, ""), \
- DEFINE_PROP_NETDEV("netdev", _state, _conf.peer, "")
+ DEFINE_PROP_MACADDR("mac", _state, _conf.macaddr, \
+ "The MAC address for the NIC."), \
+ DEFINE_PROP_VLAN("vlan", _state, _conf.vlan, \
+ "The VLAN to associate the NIC with."), \
+ DEFINE_PROP_NETDEV("netdev", _state, _conf.peer, \
+ "The peer net device to associate with this virtual NIC.")
/* VLANs support */
--
1.7.0.1
next prev parent reply other threads:[~2010-05-31 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 12:41 [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text Amit Shah
2010-05-31 12:41 ` [Qemu-devel] [PATCH 1/5] qdev: Add a description field for qdev properties for documentation Amit Shah
2010-05-31 12:41 ` [Qemu-devel] [PATCH 2/5] virtio-serial: Add description fields for qdev properties Amit Shah
2010-05-31 12:41 ` Amit Shah [this message]
2010-05-31 12:41 ` [Qemu-devel] [PATCH 4/5] qdev: Re-arrange code to have device properties shown from own function Amit Shah
2010-05-31 12:41 ` [Qemu-devel] [PATCH 5/5] qdev: Add new '-device help' option, shows all devices and properties Amit Shah
2010-06-07 14:43 ` Markus Armbruster
2010-06-08 5:13 ` Amit Shah
2010-06-07 16:09 ` [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text Anthony Liguori
2010-06-08 5:21 ` Amit Shah
2010-06-14 16:55 ` Anthony Liguori
2010-06-15 9:17 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dea337d424950963a04d39c3d8953b66451b3889.1275309375.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).