From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faAx8-0006Sm-Tt for qemu-devel@nongnu.org; Mon, 02 Jul 2018 22:22:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faAx4-0007mO-TA for qemu-devel@nongnu.org; Mon, 02 Jul 2018 22:22:02 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38262 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1faAx4-0007m8-OL for qemu-devel@nongnu.org; Mon, 02 Jul 2018 22:21:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C6783466D for ; Tue, 3 Jul 2018 02:21:58 +0000 (UTC) References: <20180702162218.13678-1-armbru@redhat.com> <20180702162218.13678-24-armbru@redhat.com> From: Eric Blake Message-ID: Date: Mon, 2 Jul 2018 21:21:57 -0500 MIME-Version: 1.0 In-Reply-To: <20180702162218.13678-24-armbru@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 23/32] qmp: Use QDict * instead of QObject * for response objects List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peterx@redhat.com, stefanha@redhat.com, dgilbert@redhat.com On 07/02/2018 11:22 AM, Markus Armbruster wrote: > By using the more specific type, we get fewer downcasts. The > downcasts are safe, but not obviously so, at least not locally. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org