From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Kashyap Chamarthy <kchamart@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu block <qemu-block@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Dave Gilbert <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194)
Date: Tue, 29 Aug 2017 16:16:54 -0500 [thread overview]
Message-ID: <defa8205-e31e-9199-c929-f2e22849e8c7@redhat.com> (raw)
In-Reply-To: <CAJSP0QUSXyb8MNVf6Tq8hLgb2wVWLX6GVAPgG-mmrGCxAEOcXg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote:
> On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy <kchamart@redhat.com> wrote:
>> This is the follow-up patch that was discussed[*] as part of feedback to
>> qemu-iotest 194.
>>
>> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
>> ---
>> Changes in v3:
>> - Wait for migration to complete before issuing `block-job-cancel`
>> (StefanH)
>> - Wait for the event BLOCK_JOB_COMPLETED on the source before stopping
>> the NBD server on the destination (StefanH)
>>
>> Changes in v2:
>> - Check for both the events: MIGRATION and BLOCK_JOB_COMPLETED (EricB)
>> ---
>> tests/qemu-iotests/194 | 23 +++++++++++++++++------
>> tests/qemu-iotests/194.out | 11 ++++++++---
>> 2 files changed, 25 insertions(+), 9 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks; I've added this to my NBD queue (pull request to come shortly
after 2.11 release is finalized), since the test uses NBD.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-08-29 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 16:50 [Qemu-devel] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194) Kashyap Chamarthy
2017-08-29 17:42 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-29 21:16 ` Eric Blake [this message]
2017-08-30 9:05 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=defa8205-e31e-9199-c929-f2e22849e8c7@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=kchamart@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).