From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmnsi-0005cn-NS for qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmnsh-0000Mv-M2 for qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:17:08 -0400 References: <20170829165058.8229-1-kchamart@redhat.com> From: Eric Blake Message-ID: Date: Tue, 29 Aug 2017 16:16:54 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JdTAfmD3fQk72HU9lGFoTRM9XNFaLEjqK" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Kashyap Chamarthy Cc: Kevin Wolf , Fam Zheng , qemu block , qemu-devel , Dave Gilbert , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JdTAfmD3fQk72HU9lGFoTRM9XNFaLEjqK From: Eric Blake To: Stefan Hajnoczi , Kashyap Chamarthy Cc: Kevin Wolf , Fam Zheng , qemu block , qemu-devel , Dave Gilbert , Stefan Hajnoczi Message-ID: Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194) References: <20170829165058.8229-1-kchamart@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote: > On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy wrote: >> This is the follow-up patch that was discussed[*] as part of feedback = to >> qemu-iotest 194. >> >> Signed-off-by: Kashyap Chamarthy >> --- >> Changes in v3: >> - Wait for migration to complete before issuing `block-job-cancel` >> (StefanH) >> - Wait for the event BLOCK_JOB_COMPLETED on the source before stoppin= g >> the NBD server on the destination (StefanH) >> >> Changes in v2: >> - Check for both the events: MIGRATION and BLOCK_JOB_COMPLETED (EricB= ) >> --- >> tests/qemu-iotests/194 | 23 +++++++++++++++++------ >> tests/qemu-iotests/194.out | 11 ++++++++--- >> 2 files changed, 25 insertions(+), 9 deletions(-) >=20 > Reviewed-by: Stefan Hajnoczi Thanks; I've added this to my NBD queue (pull request to come shortly after 2.11 release is finalized), since the test uses NBD. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --JdTAfmD3fQk72HU9lGFoTRM9XNFaLEjqK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlml2cYACgkQp6FrSiUn Q2oSzQf/XMgPvCJ+gcomEBZUfwsf9B6wFaNdxh49Z9wdyFySpI37fyCgNktZ41NV 65r4bcqTtdjAtrNRNgMHwO42qp8vUZP4SrJxY/ymgKjxxshhkk8Q266Fs8mF//Au pos7lIGyenj1DuqgXVWBH3orwwPae39kIR9KaeYYBrf8uOps+bA3dDI8JLR7Z6J+ FefDwgFO+G8y1je251FOWoX4zJtcVC8Rr1BKoAGjJb2sU03zb1uPRGcZoqCkWqzF MPpzeyss50V6cGRbgaSUZDP4ujLJXYZL3hqNjgD6eiARtwzcEO3c1eJdpS2yupQK eb2uoJ/9DvnFPSHTwCy8M37uuZ+rlQ== =rpPl -----END PGP SIGNATURE----- --JdTAfmD3fQk72HU9lGFoTRM9XNFaLEjqK--