qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Li Feng" <fengli@smartx.com>,
	"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	qemu-block@nongnu.org
Subject: [PULL 73/83] vhost: move and rename the conn retry times
Date: Wed, 18 Oct 2023 11:58:56 -0400	[thread overview]
Message-ID: <defb50258fc7bc7386c4666f69e9d73590580b6c.1697644299.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1697644299.git.mst@redhat.com>

From: Li Feng <fengli@smartx.com>

Multiple devices need this macro, move it to a common header.

Signed-off-by: Li Feng <fengli@smartx.com>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Message-Id: <20231009044735.941655-3-fengli@smartx.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/virtio/vhost.h   | 2 ++
 hw/block/vhost-user-blk.c   | 4 +---
 hw/virtio/vhost-user-gpio.c | 3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
index 00e0a669b8..5e8183f64a 100644
--- a/include/hw/virtio/vhost.h
+++ b/include/hw/virtio/vhost.h
@@ -8,6 +8,8 @@
 #define VHOST_F_DEVICE_IOTLB 63
 #define VHOST_USER_F_PROTOCOL_FEATURES 30
 
+#define VU_REALIZE_CONN_RETRIES 3
+
 /* Generic structures common for any vhost based device. */
 
 struct vhost_inflight {
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index eecf3f7a81..3c69fa47d5 100644
--- a/hw/block/vhost-user-blk.c
+++ b/hw/block/vhost-user-blk.c
@@ -32,8 +32,6 @@
 #include "sysemu/sysemu.h"
 #include "sysemu/runstate.h"
 
-#define REALIZE_CONNECTION_RETRIES 3
-
 static const int user_feature_bits[] = {
     VIRTIO_BLK_F_SIZE_MAX,
     VIRTIO_BLK_F_SEG_MAX,
@@ -482,7 +480,7 @@ static void vhost_user_blk_device_realize(DeviceState *dev, Error **errp)
     s->inflight = g_new0(struct vhost_inflight, 1);
     s->vhost_vqs = g_new0(struct vhost_virtqueue, s->num_queues);
 
-    retries = REALIZE_CONNECTION_RETRIES;
+    retries = VU_REALIZE_CONN_RETRIES;
     assert(!*errp);
     do {
         if (*errp) {
diff --git a/hw/virtio/vhost-user-gpio.c b/hw/virtio/vhost-user-gpio.c
index 3d7fae3984..fc784e4213 100644
--- a/hw/virtio/vhost-user-gpio.c
+++ b/hw/virtio/vhost-user-gpio.c
@@ -15,7 +15,6 @@
 #include "standard-headers/linux/virtio_ids.h"
 #include "trace.h"
 
-#define REALIZE_CONNECTION_RETRIES 3
 #define VHOST_NVQS 2
 
 /* Features required from VirtIO */
@@ -365,7 +364,7 @@ static void vu_gpio_device_realize(DeviceState *dev, Error **errp)
     qemu_chr_fe_set_handlers(&gpio->chardev, NULL, NULL, vu_gpio_event, NULL,
                              dev, NULL, true);
 
-    retries = REALIZE_CONNECTION_RETRIES;
+    retries = VU_REALIZE_CONN_RETRIES;
     g_assert(!*errp);
     do {
         if (*errp) {
-- 
MST



  parent reply	other threads:[~2023-10-18 16:11 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 15:53 [PULL 00/83] virtio,pc,pci: features, cleanups Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 01/83] vdpa: Use iovec for vhost_vdpa_net_cvq_add() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 02/83] vdpa: Avoid using vhost_vdpa_net_load_*() outside vhost_vdpa_net_load() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 03/83] vdpa: Check device ack in vhost_vdpa_net_load_rx_mode() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 04/83] vdpa: Move vhost_svq_poll() to the caller of vhost_vdpa_net_cvq_add() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 05/83] vdpa: Introduce cursors to vhost_vdpa_net_loadx() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 06/83] vhost: Expose vhost_svq_available_slots() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 07/83] vdpa: Send cvq state load commands in parallel Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 08/83] vdpa: Restore hash calculation state Michael S. Tsirkin
2023-10-19 16:32   ` Stefan Hajnoczi
2023-10-19 18:07     ` Michael S. Tsirkin
2023-10-20  0:58       ` Hawkins Jiawei
2023-10-19 18:34     ` Michael S. Tsirkin
2023-10-19 18:49       ` Stefan Hajnoczi
2023-10-18 15:53 ` [PULL 09/83] vdpa: Allow VIRTIO_NET_F_HASH_REPORT in SVQ Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 10/83] vdpa: Add SetSteeringEBPF method for NetClientState Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 11/83] vdpa: Restore receive-side scaling state Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 12/83] vdpa: Allow VIRTIO_NET_F_RSS in SVQ Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 13/83] tests: test-smp-parse: Add the test for cores/threads per socket helpers Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 14/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 15/83] tests: bios-tables-test: Add test for smbios type4 count Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 16/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 17/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core " Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 18/83] tests: bios-tables-test: Add test for smbios type4 core count Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 19/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 core count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 20/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core count2 test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 21/83] tests: bios-tables-test: Extend smbios core count2 test to cover general topology Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 22/83] tests: bios-tables-test: Update ACPI table binaries for smbios core count2 test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 23/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 24/83] tests: bios-tables-test: Add test for smbios type4 thread count Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 25/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count test Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 26/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count2 test Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 27/83] tests: bios-tables-test: Add test for smbios type4 thread count2 Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 28/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count2 test Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 29/83] vhost-user: strip superfluous whitespace Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 30/83] vhost-user: tighten "reply_supported" scope in "set_vring_addr" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 31/83] vhost-user: factor out "vhost_user_write_sync" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 32/83] vhost-user: flatten "enforce_reply" into "vhost_user_write_sync" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 33/83] vhost-user: hoist "write_sync", "get_features", "get_u64" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 34/83] vhost-user: allow "vhost_set_vring" to wait for a reply Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 35/83] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 36/83] memory: initialize 'fv' in MemoryRegionCache to make Coverity happy Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 37/83] vhost-user: do not send RESET_OWNER on device reset Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 38/83] vhost-backend: remove vhost_kernel_reset_device() Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 39/83] virtio: call ->vhost_reset_device() during reset Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 40/83] hw/i386/acpi-build: Remove build-time assertion on PIIX/ICH9 reset registers being identical Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 41/83] timer/i8254: Fix one shot PIT mode Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 42/83] hw/display: fix memleak from virtio_add_resource Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 43/83] hw/i386/pc: Merge two if statements into one Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 44/83] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 45/83] hw/i386/pc_piix: Assign PIIX3's ISA interrupts before its realize() Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 46/83] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 47/83] hw/i386/pc_piix: Wire PIIX3's ISA interrupts by new "isa-irqs" property Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 48/83] hw/i386/pc_piix: Remove redundant "piix3" variable Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 49/83] hw/isa/piix3: Rename "pic" attribute to "isa_irqs_in" Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 50/83] hw/i386/pc_q35: Wire ICH9 LPC function's interrupts before its realize() Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 51/83] hw/isa/piix3: Wire PIC IRQs to ISA bus in host device Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 52/83] hw/i386/pc: Wire RTC ISA IRQs in south bridges Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 53/83] hw/isa/piix3: Create IDE controller in host device Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 54/83] hw/isa/piix3: Create USB " Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 55/83] hw/isa/piix3: Create power management " Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 56/83] hw/isa/piix3: Drop the "3" from PIIX base class name Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 57/83] hw/isa/piix4: Remove unused inbound ISA interrupt lines Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 58/83] hw/isa/piix4: Rename "isa" attribute to "isa_irqs_in" Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 59/83] hw/isa/piix4: Rename reset control operations to match PIIX3 Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 60/83] hw/isa/piix4: Reuse struct PIIXState from PIIX3 Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 61/83] hw/isa/piix3: Merge hw/isa/piix4.c Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 62/83] hw/isa/piix: Allow for optional PIC creation in PIIX3 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 63/83] hw/isa/piix: Allow for optional PIT " Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 64/83] hw/isa/piix: Harmonize names of reset control memory regions Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 65/83] hw/isa/piix: Share PIIX3's base class with PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 66/83] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 67/83] hw/isa/piix: Rename functions to be shared for PCI interrupt triggering Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 68/83] hw/isa/piix: Reuse PIIX3's PCI interrupt triggering in PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 69/83] hw/isa/piix: Resolve duplicate code regarding PCI interrupt wiring Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 70/83] hw/isa/piix: Implement multi-process QEMU support also for PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 71/83] hw/i386/pc_piix: Make PIIX4 south bridge usable in PC machine Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 72/83] vhost-user-common: send get_inflight_fd once Michael S. Tsirkin
2023-10-18 15:58 ` Michael S. Tsirkin [this message]
2023-10-18 15:59 ` [PULL 74/83] vhost-user-scsi: support reconnect to backend Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 75/83] vhost-user-scsi: start vhost when guest kicks Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 76/83] vhost-user: fix lost reconnect Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 77/83] hw/i386/cxl: ensure maxram is greater than ram size for calculating cxl range Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 78/83] tests/acpi: Allow update of DSDT.cxl Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 79/83] hw/cxl: Add QTG _DSM support for ACPI0017 device Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 80/83] tests/acpi: Update DSDT.cxl with QTG DSM Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 81/83] vhost-user: Fix protocol feature bit conflict Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 82/83] MAINTAINERS: Add include/hw/intc/i8259.h to the PC chip section Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 83/83] intel-iommu: Report interrupt remapping faults, fix return value Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=defb50258fc7bc7386c4666f69e9d73590580b6c.1697644299.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=fengli@smartx.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=raphael.norwitz@nutanix.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).