From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Ninad Palsule <ninad@linux.ibm.com>,
qemu-devel@nongnu.org, clg@kaod.org, peter.maydell@linaro.org,
andrew@aj.id.au, joe@jms.id.au
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH v2 1/1] Add vpd data for Rainier machine
Date: Tue, 23 May 2023 10:52:29 +0200 [thread overview]
Message-ID: <df00a5c0-7b59-e21c-c758-b1085d0c50b7@linaro.org> (raw)
In-Reply-To: <20230522153659.3379729-2-ninad@linux.ibm.com>
Hi Ninad,
On 22/5/23 17:36, Ninad Palsule wrote:
> The VPD data is added for system and BMC FRU. This data is fabricated.
Per
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message:
QEMU follows the usual standard for git commit messages: the first
line (which becomes the email subject line) is “subsystem: single
line summary of change”.
In this patch the subsystem is "hw/arm", but you can also use
"hw/arm/aspeed" or even "hw/arm/aspeed_eeprom" for subject prefix.
> Tested:
> - The system-vpd.service is active.
> - VPD service related to bmc is active.
... more detailed description of the patch, another blank and your
Signed-off-by: line.
Missing a blank line :)
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> ---
> hw/arm/aspeed.c | 6 ++++--
> hw/arm/aspeed_eeprom.c | 45 +++++++++++++++++++++++++++++++++++++++++-
> hw/arm/aspeed_eeprom.h | 5 +++++
> 3 files changed, 53 insertions(+), 3 deletions(-)
next prev parent reply other threads:[~2023-05-23 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:36 [PATCH v2 0/1] Add vpd data for Rainier machine Ninad Palsule
2023-05-22 15:36 ` [PATCH v2 1/1] " Ninad Palsule
2023-05-23 5:53 ` Cédric Le Goater
2023-05-23 21:28 ` Ninad Palsule
2023-05-23 8:52 ` Philippe Mathieu-Daudé [this message]
2023-05-23 21:48 ` Ninad Palsule
2023-05-24 6:01 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df00a5c0-7b59-e21c-c758-b1085d0c50b7@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joe@jms.id.au \
--cc=ninad@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).