qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	peterx@redhat.com
Subject: Re: [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests
Date: Tue, 14 Mar 2023 18:45:25 +0100	[thread overview]
Message-ID: <df010d2a-df6e-22fd-6b79-566489903cca@redhat.com> (raw)
In-Reply-To: <CAFEAcA904=NOW5236nmMWWf9-uHGdgkYHc6Z1MS7z-bRw-k04w@mail.gmail.com>

On 14/03/2023 15.17, Peter Maydell wrote:
> On Tue, 14 Mar 2023 at 14:14, Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 14/03/2023 15.08, Peter Maydell wrote:
>>> On Tue, 14 Mar 2023 at 14:01, Thomas Huth <thuth@redhat.com> wrote:
>>>>
>>>> On 14/03/2023 14.33, Peter Maydell wrote:
>>>>> The postcopy/preempt tests seem to have a race which makes them hang
>>>>> on the s390x CI runner.  Disable them for the moment, while we
>>>>> investigate.  As with the other disabled subtest, you can opt back in
>>>>> by setting QEMU_TEST_FLAKY_TESTS=1 in your environment.
>>>>>
>>>>> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>>>> ---
>>>>>     tests/qtest/migration-test.c | 23 ++++++++++++++++-------
>>>>>     1 file changed, 16 insertions(+), 7 deletions(-)
>>>>>
>>>>> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
>>>>> index d4ab3934ed2..4643f7f49dc 100644
>>>>> --- a/tests/qtest/migration-test.c
>>>>> +++ b/tests/qtest/migration-test.c
>>>>> @@ -2464,6 +2464,11 @@ int main(int argc, char **argv)
>>>>>         const char *arch = qtest_get_arch();
>>>>>         g_autoptr(GError) err = NULL;
>>>>>         int ret;
>>>>> +    /*
>>>>> +     * Race condition suspected in the postcopy/preempt tests: see
>>>>> +     * https://lore.kernel.org/qemu-devel/CAFEAcA-q1UwPePdHTzXNSX4i6Urh3j6h51kymy6=7SzDAFU87w@mail.gmail.com/
>>>>> +     */
>>>>> +    bool skip_postcopy_preempt = getenv("QEMU_TEST_FLAKY_TESTS");
>>
>> You could maybe also call the variale skip_flaky_tests and use it in the
>> other spot where you recently added a getenv() already.
> 
> That would make it a bit harder to do a simple revert of the
> commits when we figure out the cause of the problem, though.

Ok, fair.

So with the "!" added before the getenv:
Reviewed-by: Thomas Huth <thuth@redhat.com>



      reply	other threads:[~2023-03-14 17:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 13:33 [PATCH] tests/qtest/migration-test: Disable postcopy/preempt tests Peter Maydell
2023-03-14 13:42 ` Dr. David Alan Gilbert
2023-03-14 14:01 ` Thomas Huth
2023-03-14 14:08   ` Peter Maydell
2023-03-14 14:14     ` Thomas Huth
2023-03-14 14:17       ` Peter Maydell
2023-03-14 17:45         ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df010d2a-df6e-22fd-6b79-566489903cca@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).