From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v4 1/4] qemu-keymap: Make references to allocations static
Date: Mon, 27 May 2024 11:54:50 +0200 [thread overview]
Message-ID: <df2abc64-9cff-44fb-876e-11a1711ecf4c@linaro.org> (raw)
In-Reply-To: <20240524-xkb-v4-1-2de564e5c859@daynix.com>
On 24/5/24 07:35, Akihiko Odaki wrote:
> LeakSanitizer complains about allocations whose references are held
> only by automatic variables. It is possible to free them to suppress
> the complaints, but it is a chore to make sure they are freed in all
> exit paths so make them static instead.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> qemu-keymap.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-05-27 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 5:35 [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1 Akihiko Odaki
2024-05-24 5:35 ` [PATCH v4 1/4] qemu-keymap: Make references to allocations static Akihiko Odaki
2024-05-27 9:54 ` Philippe Mathieu-Daudé [this message]
2024-05-24 5:35 ` [PATCH v4 2/4] lockable: Do not cast function pointers Akihiko Odaki
2024-05-27 9:57 ` Philippe Mathieu-Daudé
2024-05-27 10:05 ` Philippe Mathieu-Daudé
2024-05-24 5:35 ` [PATCH v4 3/4] qapi: " Akihiko Odaki
2024-05-28 11:02 ` Markus Armbruster
2024-05-24 5:35 ` [PATCH v4 4/4] meson: Drop the .fa library suffix Akihiko Odaki
2024-05-29 7:39 ` [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1 Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df2abc64-9cff-44fb-876e-11a1711ecf4c@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).