From: Auger Eric <eric.auger@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, peter.maydell@linaro.org, cohuck@redhat.com
Cc: drjones@redhat.com
Subject: Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default
Date: Tue, 28 Apr 2020 13:01:17 +0200 [thread overview]
Message-ID: <df3080eb-80d6-5dab-6fd8-973a3764ab5c@redhat.com> (raw)
In-Reply-To: <a5bb0ccb-2dc4-67e2-f0df-98c349e6e94f@linux.ibm.com>
Hi Stefan,
On 4/27/20 10:21 PM, Stefan Berger wrote:
> On 4/27/20 10:31 AM, Eric Auger wrote:
>> Instead of using a compat in the mach-virt machine to force
>> PPI off for all virt machines (PPI not supported by the
>> tpm-tis-device device), let's simply change the default value
>> in the sysbus device.
>
> There is no change in behavior on any arm machine due to this patch,
> right? So backporting would not be necessary?
Indeed, there is no functional change as we keep PPI off. My
understanding is we can safely remove the compat mechanism. I tested
migration between virt machine with compat to virt machine without
compat and conversely (without tpm-tis-device though) and it passed.
Thanks
Eric
>
>
> Stefan
>
>
next prev parent reply other threads:[~2020-04-28 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:31 [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default Eric Auger
2020-04-27 14:31 ` [PATCH 1/2] tpm: tpm-tis-device: set PPI to false " Eric Auger
2020-04-28 10:34 ` Cornelia Huck
2020-04-28 20:13 ` Stefan Berger
2020-04-27 14:31 ` [PATCH 2/2] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off Eric Auger
2020-04-28 10:36 ` Cornelia Huck
2020-04-28 20:14 ` Stefan Berger
2020-04-27 20:21 ` [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default Stefan Berger
2020-04-28 11:01 ` Auger Eric [this message]
2020-04-28 10:38 ` Cornelia Huck
2020-04-28 20:13 ` Stefan Berger
2020-04-29 6:11 ` Cornelia Huck
2020-04-29 11:53 ` Stefan Berger
2020-05-01 9:40 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df3080eb-80d6-5dab-6fd8-973a3764ab5c@redhat.com \
--to=eric.auger@redhat.com \
--cc=cohuck@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).