From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Patrick Leis <venture@google.com>,
clg@kaod.org, peter.maydell@linaro.org,
steven_lee@aspeedtech.com, Troy Lee <leetroy@gmail.com>,
jamin_lin@aspeedtech.com, joel@jms.id.au
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm: enable at24c with aspeed
Date: Tue, 29 Oct 2024 11:13:14 +1030 [thread overview]
Message-ID: <df317f3f9f70340669f032377328765b81b3e493.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20241028181420.1438938-1-venture@google.com>
On Mon, 2024-10-28 at 18:14 +0000, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
>
> Signed-off-by: Patrick Leis <venture@google.com>
I was wondering how we haven't hit problems before now. Poking around
with scripts/minikconf.py for an arm-softmmu build we get:
# config AT24C depends on I2C
# select AT24C if NPCM7XX
# => AT24C is now True
# config AT24C default y if E500
# config AT24C default n
Seems reasonable that the Aspeed models should select it themselves
given they depend on the symbols.
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
next prev parent reply other threads:[~2024-10-29 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 18:14 [PATCH] hw/arm: enable at24c with aspeed Patrick Leis
2024-10-28 18:19 ` Hao Wu
2024-10-29 0:43 ` Andrew Jeffery [this message]
2024-10-29 4:58 ` Philippe Mathieu-Daudé
2024-11-02 14:58 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df317f3f9f70340669f032377328765b81b3e493.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).