From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68D5C4BA18 for ; Wed, 26 Feb 2020 18:19:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8400A24650 for ; Wed, 26 Feb 2020 18:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uq16kaxE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8400A24650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j71HT-0008J2-P0 for qemu-devel@archiver.kernel.org; Wed, 26 Feb 2020 13:19:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44163) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j71Gq-0007m0-Bf for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:18:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j71Gp-0001ia-BP for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:18:56 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:40023 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j71Gp-0001iI-6Z for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:18:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582741134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2o73uRGSBgrIBM185jP59p4QfYDtNl6ohT6e8UTynUs=; b=Uq16kaxEm+QaHBqi34Oq/Jxm/DbVM70nsLmNIGDJYxkkJ+vWtGc3dqEokRUFxQ0rRqDjnL DCnojISimKmuI4I2eOx901DyN1Pk/g8JmrEA7TUTd7P4gY8YuR/oH4aLI0gpflI6crqI0s DTNJvgfNpYCgTg3o6zWxH9M7cplvBLQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-0ZwuJ56-OfaJHDNxElU1dQ-1; Wed, 26 Feb 2020 13:18:53 -0500 X-MC-Unique: 0ZwuJ56-OfaJHDNxElU1dQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9AD01801E5C; Wed, 26 Feb 2020 18:18:51 +0000 (UTC) Received: from [10.36.116.59] (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBC20101D482; Wed, 26 Feb 2020 18:18:46 +0000 (UTC) Subject: Re: [PATCH v3 00/10] vTPM for aarch64 To: Stefan Berger , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org References: <20200226102549.12158-1-eric.auger@redhat.com> <31e81f4b-ef00-692e-540f-ef3d9be5bb9a@linux.ibm.com> <22380cd3-b13e-aede-a7f5-158d86ca6136@redhat.com> From: Auger Eric Message-ID: Date: Wed, 26 Feb 2020 19:18:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, lersek@redhat.com, ardb@kernel.org, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Stefan, On 2/26/20 6:53 PM, Stefan Berger wrote: > On 2/26/20 12:47 PM, Auger Eric wrote: >> Hi Stefan, >> >> On 2/26/20 2:32 PM, Stefan Berger wrote: >>> On 2/26/20 5:25 AM, Eric Auger wrote: >>>> This series adds the capability to instantiate an MMIO TPM TIS >>>> in ARM virt. It is candidate to qemu 5.0. >>> Looks good. Can you run the checkpatch script over the patches and >>> address the warnings? >>> >>> >> Thank you for you review! >> >> About warnings >> >> - There are warnings due to new files added but I think they all have an >> entry in MAINTAINERS as wildcards are used. >> >> - In tpm: Add the SysBus TPM TIS device. >> =C2=A0=C2=A0 There is line over 80 chars but I think it is fine >> >> #define TPM_TIS_SYSBUS(obj) OBJECT_CHECK(TPMStateSysBus, (obj), >> TYPE_TPM_TIS_SYSBUS) >=20 >=20 > Ok, leave it as it is. and sorry, what about the comment style issues derived from existing files? " - test: tpm-tis: Get prepared to share tests between ISA and sysbus devices has lots of warnings due to old comment style being used in tests/qtest/tpm-tis-test.c. I did not fix the style issue because I just copy the code into tpm-tis-util.c Do you want me to fix them in the same patch, in a separate patch or ignore the style issue for now? " Thanks Eric >=20 >=20 > =C2=A0=C2=A0 Stefan >=20 >=20