Re: [PATCH 10/25] target/i386: finish converting 0F AE to the new decoder

[Richard Henderson <richard.henderson@linaro.org>]

On 6/8/24 01:40, Paolo Bonzini wrote:
> +static void gen_FXRSTOR(DisasContext *s, X86DecodedInsn *decode)
> +{
> +    if ((s->flags & HF_EM_MASK) || (s->flags & HF_TS_MASK)) {
> +        gen_NM_exception(s);
> +    }
> +    gen_helper_fxrstor(tcg_env, s->A0);
> +}
> +
> +static void gen_FXSAVE(DisasContext *s, X86DecodedInsn *decode)
> +{
> +    if ((s->flags & HF_EM_MASK) || (s->flags & HF_TS_MASK)) {
> +        gen_NM_exception(s);
> +    }
> +    gen_helper_fxsave(tcg_env, s->A0);
> +}

You want else's here, to not emit fxsave/restore after raising NM.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~