From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 13/16] tcg/aarch64: Return false on failure from patch_reloc
Date: Mon, 3 Dec 2018 07:23:27 -0600 [thread overview]
Message-ID: <df59c0c0-6943-4ed1-a1f9-86a744e741ae@linaro.org> (raw)
In-Reply-To: <87y3963n7v.fsf@linaro.org>
On 12/3/18 4:43 AM, Alex Bennée wrote:
>> case R_AARCH64_CONDBR19:
>> - reloc_pc19(code_ptr, (tcg_insn_unit *)value);
>> - break;
>> + return reloc_pc19(code_ptr, (tcg_insn_unit *)value);
>> default:
>> tcg_abort();
>> }
>> - return true;
>
> nit: the default leg could return false for the same effect
Would it be clearer changed to g_assert_not_reached()?
Because I'm not intending "unknown relocation" to have
the same effect as "out of range relocation".
r~
next prev parent reply other threads:[~2018-12-03 13:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 21:52 [Qemu-devel] [PATCH v3 00/16] tcg: Assorted cleanups Richard Henderson
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 01/16] tcg/i386: Always use %ebp for TCG_AREG0 Richard Henderson
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 02/16] tcg/i386: Move TCG_REG_CALL_STACK from define to enum Richard Henderson
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 03/16] tcg/aarch64: Remove reloc_pc26_atomic Richard Henderson
2018-12-03 8:44 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 04/16] tcg/aarch64: Fold away "noaddr" branch routines Richard Henderson
2018-12-03 15:49 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 05/16] tcg/arm: Remove reloc_pc24_atomic Richard Henderson
2018-12-03 15:49 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 06/16] tcg/arm: Fold away "noaddr" branch routines Richard Henderson
2018-12-03 10:33 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 07/16] tcg/ppc: " Richard Henderson
2018-12-03 10:35 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 08/16] tcg/s390: Remove retranslation code Richard Henderson
2018-12-03 10:37 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 09/16] tcg/sparc: " Richard Henderson
2018-12-03 10:39 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 10/16] tcg/mips: " Richard Henderson
2018-12-03 10:39 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 11/16] tcg: Return success from patch_reloc Richard Henderson
2018-12-03 10:40 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 12/16] tcg/i386: Return false on failure " Richard Henderson
2018-12-03 10:40 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 13/16] tcg/aarch64: " Richard Henderson
2018-12-03 10:43 ` Alex Bennée
2018-12-03 13:23 ` Richard Henderson [this message]
2018-12-03 14:15 ` Alex Bennée
2018-12-03 14:31 ` Richard Henderson
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 14/16] tcg/arm: " Richard Henderson
2018-12-03 10:43 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 15/16] tcg/ppc: " Richard Henderson
2018-12-03 10:44 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 16/16] tcg/s390x: " Richard Henderson
2018-12-03 10:46 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df59c0c0-6943-4ed1-a1f9-86a744e741ae@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).