qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Eric Blake" <eblake@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup
Date: Thu, 28 Jun 2018 17:51:21 +0200	[thread overview]
Message-ID: <df642a2c-b7af-40ef-9fdf-defd75b501f0@redhat.com> (raw)
In-Reply-To: <85bdb202-2211-8d06-105b-86efb307f961@redhat.com>

On 28/06/2018 16:46, Eric Blake wrote:
> On 06/28/2018 08:28 AM, Paolo Bonzini wrote:
>> On 28/06/2018 15:22, Eric Blake wrote:
>>>>>
>>>>> -qemu-system-i386 [...OPTIONS...] -vnc :1,tls,x509=/etc/pki/qemu
>>>>> -monitor stdio
>>>>> +qemu-system-i386 [...OPTIONS...] \
>>>>> +  -object
>>>>> tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=no
>>>>>
>>>>> \
>>>
>>> I'd use --object here (especially since -object cannot be used on
>>> qemu-nbd, but --object tls-creds-x509 can).
>>
>> But that would be inconsistent with -vnc.
>>
>> I honestly don't understand the crusade against single-dashed options.
> 
> Rather, it's a crusade FOR the use of --object, for consistency reasons:
> 
> These work:
> 
> qemu-system-i386 -object foo
> qemu-system-i386 --object foo
> qemu-nbd --object foo
> 
> but this fails:
> 
> qemu-nbd -object foo
> 
> And since --object blurbs can a) be quite long, and b) be quite useful
> for pasting between apps, then it stands to reason that our
> documentation should prefer the form that is easiest to reuse everywhere.

It's also inconsistent with the rest of the command line, though, and it
may wrongly give the impression that single-character options can be
combined.

Paolo

  reply	other threads:[~2018-06-28 15:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 10:10 [Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup Daniel P. Berrangé
2018-06-28 13:17 ` Daniel P. Berrangé
2018-06-28 13:21   ` Paolo Bonzini
2018-06-28 13:22   ` Eric Blake
2018-06-28 13:28     ` Paolo Bonzini
2018-06-28 14:46       ` Eric Blake
2018-06-28 15:51         ` Paolo Bonzini [this message]
2018-06-28 16:29       ` Daniel P. Berrangé
2018-06-28 20:04         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df642a2c-b7af-40ef-9fdf-defd75b501f0@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).