From: "Andrew Jeffery" <andrew@aj.id.au>
To: erik-smit <erik.lucas.smit@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Cameron Esfahani via" <qemu-devel@nongnu.org>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v2] ftgmac100: fix dblac write test
Date: Mon, 06 Jul 2020 11:29:24 +0930 [thread overview]
Message-ID: <df64d8de-9d7f-474b-8b72-5d2e6c7df1f4@www.fastmail.com> (raw)
In-Reply-To: <20200628142658.29264-1-erik.lucas.smit@gmail.com>
On Sun, 28 Jun 2020, at 23:56, erik-smit wrote:
> The test of the write of the dblac register was testing the old value
> instead of the new value. This would accept the write of an invalid value
> but subsequently refuse any following valid writes.
>
> Signed-off-by: erik-smit <erik.lucas.smit@gmail.com>
> ---
> Changes since v1:
>
> Changed %ld to HWADDR_PRIx to fix building on mingw
Bit of a nitpick, but the type of the value argument is uint64_t, so shouldn't
the result of the expression captured by FTGMAC100_DBLAC_TXDES_SIZE() and
FTGMAC100_DBLAC_RXDES_SIZE() be printed with a straight PRIx64 rather than
HWADDR_PRIx?
Otherwise the change seems sensible, so:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
next prev parent reply other threads:[~2020-07-06 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 14:26 [PATCH v2] ftgmac100: fix dblac write test erik-smit
2020-07-06 1:59 ` Andrew Jeffery [this message]
2020-07-07 7:42 ` Erik Smit
2020-07-13 12:06 ` Cédric Le Goater
2020-07-14 9:04 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df64d8de-9d7f-474b-8b72-5d2e6c7df1f4@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=erik.lucas.smit@gmail.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).