From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLVnz-0005zj-0o for qemu-devel@nongnu.org; Fri, 08 Jul 2016 09:26:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLVnu-0005K2-7H for qemu-devel@nongnu.org; Fri, 08 Jul 2016 09:26:54 -0400 References: <20160707084249.29084-1-fullmanet@gmail.com> From: Max Reitz Message-ID: Date: Fri, 8 Jul 2016 15:26:37 +0200 MIME-Version: 1.0 In-Reply-To: <20160707084249.29084-1-fullmanet@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2oDLtPxEin6lRcrHmwk3Xn3STxFif35aH" Subject: Re: [Qemu-devel] [PATCH v2] vmdk: fix metadata write regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Reda Sallahi , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Fam Zheng , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2oDLtPxEin6lRcrHmwk3Xn3STxFif35aH From: Max Reitz To: Reda Sallahi , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Fam Zheng , Kevin Wolf Message-ID: Subject: Re: [PATCH v2] vmdk: fix metadata write regression References: <20160707084249.29084-1-fullmanet@gmail.com> In-Reply-To: <20160707084249.29084-1-fullmanet@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 07.07.2016 10:42, Reda Sallahi wrote: > Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on > writes. It writes metadata after every write instead of doing it only o= nce > for each cluster. >=20 > vmdk_pwritev() writes metadata whenever m_data is set as valid so this = patch > sets m_data as valid only when we have a new cluster which hasn't been > allocated before or a zero grain. >=20 > Signed-off-by: Reda Sallahi > --- > v2: Corrected the commit id referenced in the commit message. >=20 > block/vmdk.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Thanks Reda, I've applied the patch to my block branch: https://github.com/XanClic/qemu/commits/block Max --2oDLtPxEin6lRcrHmwk3Xn3STxFif35aH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXf6oNEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrT8U CACl/CqzHduAjERrxBivEz8sBuCVndi3JAzu3/ArNdYcLHqdtoZP5eVuRJpxpQiQ ut6rg2WneIpTH+xGGq1ASbi33Kh8jzec1exurAXHQ6YLqxR1sFauXNrEAlOC8nN6 IJgngoL9oih+sYjdTjAdzWRiHes5aZL4wD0fy0b/fXp2NTRbgXUDTNOXOsJ5cGou TglttOHhuhs4b93FTw+577+lDtNGCT8p1PwXrGZpfIN3IYmUaqQ1BlHMYb0MJ5Yt wCi18oZII35YOU6A4HHMW+qNNQt3t2h2U7O6Xt22rxdyxR4d2KpQVu0oVCBKKz52 2S++rcqQ8DqECtW2gsZrSmXb =oJDS -----END PGP SIGNATURE----- --2oDLtPxEin6lRcrHmwk3Xn3STxFif35aH--