From: David Woodhouse <dwmw2@infradead.org>
To: paul@xen.org, qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event channel GSI
Date: Tue, 07 Jan 2025 16:58:26 +0000 [thread overview]
Message-ID: <df85c04746a36d6467821ed57c93709dceee4e33.camel@infradead.org> (raw)
In-Reply-To: <e0eec24c-dd22-4b95-8e62-60d9107b2ae0@xen.org>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Tue, 2025-01-07 at 16:38 +0000, Paul Durrant wrote:
>
> > +#ifdef CONFIG_XEN_EMU
> > + /*
> > + * Xen delivers the GSI to the Legacy PIC (not that Legacy PIC
> > + * routing actually works properly under Xen). And then to
> > + * *either* the PIRQ handling or the I/OAPIC depending on
> > + * whether the former wants it.
> > + *
> > + * Additionally, this hook allows the Xen event channel GSI to
> > + * work around QEMU's lack of support for shared level interrupts,
> > + * by keeping track of the externally driven state of the pin and
> > + * implementing a logical OR with the state of the evtchn GSI.
> > + */
>
> Looks like something went wrong with the indent here.
Fixed the indentation for the comment to 4 spaces in my tree; thanks.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2025-01-07 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 16:32 [PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event channel GSI David Woodhouse
2025-01-07 16:38 ` Paul Durrant
2025-01-07 16:58 ` David Woodhouse [this message]
2025-01-07 16:44 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2025-01-08 12:12 David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df85c04746a36d6467821ed57c93709dceee4e33.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).