From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdMKl-0004zS-FM for qemu-devel@nongnu.org; Sat, 29 Dec 2018 16:39:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gdMKg-0006sj-Iq for qemu-devel@nongnu.org; Sat, 29 Dec 2018 16:39:51 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:38342) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gdMKg-0006qZ-9Q for qemu-devel@nongnu.org; Sat, 29 Dec 2018 16:39:46 -0500 Received: by mail-pg1-x544.google.com with SMTP id g189so11384568pgc.5 for ; Sat, 29 Dec 2018 13:39:46 -0800 (PST) References: <20181228135235.6859-1-mark.cave-ayland@ilande.co.uk> <20181228135235.6859-8-mark.cave-ayland@ilande.co.uk> From: Richard Henderson Message-ID: Date: Sun, 30 Dec 2018 08:39:38 +1100 MIME-Version: 1.0 In-Reply-To: <20181228135235.6859-8-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 7/8] target/ppc: remove ROTRu32 and ROTRu64 macros from int_helper.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au On 12/29/18 12:52 AM, Mark Cave-Ayland wrote: > Richard points out that these macros suffer from a -fsanitize=shift bug in that > they improperly handle n == 0 turning it into a shift by 32/64 respectively. > Replace them with QEMU's existing ror32() and ror64() functions instead. > > Signed-off-by: Mark Cave-Ayland > --- > target/ppc/int_helper.c | 48 ++++++++++++++++++++---------------------------- > 1 file changed, 20 insertions(+), 28 deletions(-) Reviewed-by: Richard Henderson r~