From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467CAC64E7A for ; Tue, 1 Dec 2020 06:05:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 535362087D for ; Tue, 1 Dec 2020 06:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 535362087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjynH-0004VW-P9 for qemu-devel@archiver.kernel.org; Tue, 01 Dec 2020 01:05:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjym6-0003qx-FD for qemu-devel@nongnu.org; Tue, 01 Dec 2020 01:04:30 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjym3-0002JZ-RD for qemu-devel@nongnu.org; Tue, 01 Dec 2020 01:04:30 -0500 Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4ClWkW18bpzXhkH; Tue, 1 Dec 2020 14:03:47 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 1 Dec 2020 14:04:08 +0800 Received: from [10.174.187.211] (10.174.187.211) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Tue, 1 Dec 2020 14:04:07 +0800 Subject: Re: [PATCH v2 0/6] migration: Multi-thread compression method support To: Eric Blake , , References: <20201127093639.2815-1-jinzeyu@huawei.com> <2ec8cee7-5330-0e87-f593-464ba789688e@redhat.com> From: Zeyu Jin Message-ID: Date: Tue, 1 Dec 2020 14:04:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2ec8cee7-5330-0e87-f593-464ba789688e@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.211] X-ClientProxiedBy: dggemi702-chm.china.huawei.com (10.3.20.101) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.187; envelope-from=jinzeyu@huawei.com; helo=szxga01-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/12/1 0:42, Eric Blake wrote: > On 11/27/20 3:36 AM, Zeyu Jin wrote: > > Meta-comment: you appear to be having problems threading your series; > I've now seen three separate cover letters (RFC v1, v2 with no subject, > v2 with subject) and two series where each patch was a separate thread. > It is difficult to follow which messages are related when reading in a > mail client that sorts by most-recently-active thread first. You may > want to investigate why your threading is not working, although I'd wait > to send v3 until you have actual changes to incorporate. > Thank you for noticing that. It`s my mistake when sending patches. Everything will be fine in v3. >> Currently we have both multi-thread compression and multifd to optimize >> live migration in Qemu. Mulit-thread compression deals with the situation >> where network bandwith is limited but cpu resource adequate. Multifd instead > > Not that typos in the cover letter matter, but this should be 'bandwidth' > Yes, I will fix that. >> aims to take full advantage of network bandwith. Moreover it supports both >> zlib and zstd compression on each channel. >> >> In this patch series, we did some code refactoring on multi-thread compression >> live migration and bring zstd compression method support for it. >> >> Below is the test result of multi-thread compression live migration >> with different compress methods. Test result shows that zstd outperforms >> zlib by about 70%. >> >