From: Richard Henderson <richard.henderson@linaro.org>
To: Karim Taha <kariem.taha2.7@gmail.com>, qemu-devel@nongnu.org
Cc: imp@bsdimp.com, Stacey Son <sson@FreeBSD.org>
Subject: Re: [PATCH v5 22/23] bsd-user: Implement shmat(2) and shmdt(2)
Date: Fri, 15 Sep 2023 05:38:28 -0700 [thread overview]
Message-ID: <df9a0aec-52f8-5a70-eb4d-758fd7be48a0@linaro.org> (raw)
In-Reply-To: <20230914204107.23778-23-kariem.taha2.7@gmail.com>
On 9/14/23 13:41, Karim Taha wrote:
> From: Stacey Son<sson@FreeBSD.org>
>
> Use `WITH_MMAP_LOCK_GUARD` instead of mmap_lock() and mmap_unlock(),
> to match linux-user implementation, according to the following commits:
>
> 69fa2708a216df715ba5102a0f98468b540a464e linux-user: Use WITH_MMAP_LOCK_GUARD in target_{shmat,shmdt}
> ceda5688b650646248f269a992c06b11148c5759 linux-user: Fix shmdt
>
> Signed-off-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Karim Taha<kariem.taha2.7@gmail.com>
> ---
> bsd-user/bsd-mem.h | 87 +++++++++++++++++++++++++++++++++++
> bsd-user/freebsd/os-syscall.c | 8 ++++
> bsd-user/mmap.c | 2 +-
> bsd-user/qemu.h | 1 +
> 4 files changed, 97 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-09-15 12:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 20:40 [PATCH v5 00/23] bsd-user: Implement mmap related system calls for FreeBSD Karim Taha
2023-09-14 20:40 ` [PATCH v5 01/23] bsd-user: Implement struct target_ipc_perm Karim Taha
2023-09-14 20:40 ` [PATCH v5 02/23] bsd-user: Implement struct target_shmid_ds Karim Taha
2023-09-14 20:40 ` [PATCH v5 03/23] bsd-user: Declarations for ipc_perm and shmid_ds conversion functions Karim Taha
2023-09-14 20:40 ` [PATCH v5 04/23] bsd-user: Introduce freebsd/os-misc.h to the source tree Karim Taha
2023-09-14 20:40 ` [PATCH v5 05/23] bsd-user: Implement shm_open2(2) system call Karim Taha
2023-09-17 10:33 ` Warner Losh
2023-09-14 20:40 ` [PATCH v5 06/23] bsd-user: Implement shm_rename(2) " Karim Taha
2023-09-14 20:40 ` [PATCH v5 07/23] bsd-user: Add bsd-mem.c to meson.build Karim Taha
2023-09-14 20:40 ` [PATCH v5 08/23] bsd-user: Implement target_set_brk function in bsd-mem.c instead of os-syscall.c Karim Taha
2023-09-14 20:40 ` [PATCH v5 09/23] bsd-user: Implement ipc_perm conversion between host and target Karim Taha
2023-09-17 10:34 ` Warner Losh
2023-09-14 20:40 ` [PATCH v5 10/23] bsd-user: Implement shmid_ds " Karim Taha
2023-09-17 10:35 ` Warner Losh
2023-09-14 20:40 ` [PATCH v5 11/23] bsd-user: Introduce bsd-mem.h to the source tree Karim Taha
2023-09-14 20:40 ` [PATCH v5 12/23] bsd-user: Implement mmap(2) and munmap(2) Karim Taha
2023-09-14 20:40 ` [PATCH v5 13/23] bsd-user: Implement mprotect(2) Karim Taha
2023-09-14 20:40 ` [PATCH v5 14/23] bsd-user: Implement msync(2) Karim Taha
2023-09-14 20:40 ` [PATCH v5 15/23] bsd-user: Implement mlock(2), munlock(2), mlockall(2), munlockall(2), minherit(2) Karim Taha
2023-09-14 20:41 ` [PATCH v5 16/23] bsd-user: Implment madvise(2) to match the linux-user implementation Karim Taha
2023-09-17 10:38 ` Warner Losh
2023-09-14 20:41 ` [PATCH v5 17/23] bsd-user: Implement mincore(2) Karim Taha
2023-09-17 11:03 ` Warner Losh
2023-09-14 20:41 ` [PATCH v5 18/23] bsd-user: Implement do_obreak function Karim Taha
2023-09-17 11:04 ` Warner Losh
2023-09-14 20:41 ` [PATCH v5 19/23] bsd-user: Implement shm_open(2) Karim Taha
2023-09-17 11:06 ` Warner Losh
2023-09-14 20:41 ` [PATCH v5 20/23] bsd-user: Implement shm_unlink(2) and shmget(2) Karim Taha
2023-09-14 20:41 ` [PATCH v5 21/23] bsd-user: Implement shmctl(2) Karim Taha
2023-09-17 11:07 ` Warner Losh
2023-09-14 20:41 ` [PATCH v5 22/23] bsd-user: Implement shmat(2) and shmdt(2) Karim Taha
2023-09-15 12:38 ` Richard Henderson [this message]
2023-09-14 20:41 ` [PATCH v5 23/23] bsd-user: Add stubs for vadvise(), sbrk() and sstk() Karim Taha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9a0aec-52f8-5a70-eb4d-758fd7be48a0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=imp@bsdimp.com \
--cc=kariem.taha2.7@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).