From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D52C433DB for ; Mon, 15 Mar 2021 06:11:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6949564E37 for ; Mon, 15 Mar 2021 06:11:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6949564E37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLgSA-0007hf-Gp for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 02:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLgQo-0005tb-Mc for qemu-devel@nongnu.org; Mon, 15 Mar 2021 02:10:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLgQg-0006h9-7Y for qemu-devel@nongnu.org; Mon, 15 Mar 2021 02:10:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615788610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zZXxEhG1Xk+YlfmsbNhaZSdJ3JFu4VtIiXmJ0PiXGk=; b=CjdwNOj9mgKs1+kKibDdPUcXrJyFnkLpwltStTHSLTqz6bR04wz+vwyVii/IFvJ1rXZTAl 1jP8x0x4gBYu0HCENCeQC3goCtPsNf7KVEIL9yDR+fV6mxUgXgTFvufNjVArygRsnxiBZg zTWtFdvARmVu7B+zXgWlRmsPN8N0T4k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-ZDh8LINCMWOeUqOTjG3HWQ-1; Mon, 15 Mar 2021 02:10:07 -0400 X-MC-Unique: ZDh8LINCMWOeUqOTjG3HWQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA15083DD24; Mon, 15 Mar 2021 06:10:06 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-72.ams2.redhat.com [10.36.112.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 400BC5D9C0; Mon, 15 Mar 2021 06:10:05 +0000 (UTC) To: Mahmoud Mandour , qemu-devel@nongnu.org References: <20210314032324.45142-1-ma.mandourr@gmail.com> <20210314032324.45142-6-ma.mandourr@gmail.com> From: Thomas Huth Subject: Re: [PATCH 5/8] util/compatfd.c: Replaced a malloc with GLib's variant Message-ID: Date: Mon, 15 Mar 2021 07:10:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210314032324.45142-6-ma.mandourr@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14/03/2021 04.23, Mahmoud Mandour wrote: > Replaced a malloc() call and its respective free() call with > GLib's g_try_malloc() and g_free(). > > Also, did slight styling changes that were producing > style errors when using the checkpatch.pl script against > the file. If it's unrelated, then maybe better do it in a separate patch. > Signed-off-by: Mahmoud Mandour > --- > util/compatfd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/util/compatfd.c b/util/compatfd.c > index ee47dd8089..834ddd0573 100644 > --- a/util/compatfd.c > +++ b/util/compatfd.c > @@ -20,8 +20,7 @@ > #include > #endif > > -struct sigfd_compat_info > -{ > +struct sigfd_compat_info { > sigset_t mask; > int fd; > }; > @@ -53,8 +52,9 @@ static void *sigwait_compat(void *opaque) > > len = write(info->fd, (char *)&buffer + offset, > sizeof(buffer) - offset); > - if (len == -1 && errno == EINTR) > + if (len == -1 && errno == EINTR) { > continue; > + } > > if (len <= 0) { > return NULL; > @@ -72,14 +72,14 @@ static int qemu_signalfd_compat(const sigset_t *mask) > QemuThread thread; > int fds[2]; > > - info = malloc(sizeof(*info)); > + info = g_try_malloc(sizeof(*info)); > if (info == NULL) { > errno = ENOMEM; > return -1; > } Since this is only a very small allocation, I think it would be better to use g_malloc() here and then simply remove the "if (info == NULL) ..." part. Thomas