From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Haitao Shan <hshan@google.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>,
Haitao Shan <haitao.shan@google.com>,
"open list:Android Emulator..." <emu-dev@google.com>
Subject: Re: [PATCH 6/6] Add the AEHD implementation.
Date: Fri, 3 Mar 2023 11:15:43 +0100 [thread overview]
Message-ID: <dfb74ad1-a228-4a63-a01b-70e935de57d0@linaro.org> (raw)
In-Reply-To: <20230303022618.4098825-6-hshan@google.com>
On 3/3/23 03:26, Haitao Shan wrote:
> Implement the AEHD accelerator including the AEHD AccelClass,
> AccelCPUClass, AccelOpsClass.
>
> Signed-off-by: Haitao Shan <hshan@google.com>
> ---
> hw/i386/x86.c | 2 +-
> include/exec/ram_addr.h | 2 -
> include/sysemu/aehd.h | 87 ++
> include/sysemu/hw_accel.h | 1 +
> target/i386/aehd/aehd-accel-ops.c | 119 ++
> target/i386/aehd/aehd-accel-ops.h | 22 +
> target/i386/aehd/aehd-all.c | 1020 +++++++++++++++
> target/i386/aehd/aehd-cpu.c | 150 +++
> target/i386/aehd/aehd-cpu.h | 41 +
> target/i386/aehd/aehd-stub.c | 22 +
> target/i386/aehd/aehd.c | 1915 +++++++++++++++++++++++++++++
> target/i386/aehd/aehd_i386.h | 26 +
> target/i386/aehd/aehd_int.h | 2 +-
> target/i386/aehd/meson.build | 4 +
> target/i386/cpu.c | 12 +-
> target/i386/cpu.h | 5 +-
> target/i386/helper.c | 3 +
> target/i386/meson.build | 1 +
> 18 files changed, 3428 insertions(+), 6 deletions(-)
I'm not going to review a 3000+ LoC patch, sorry.
1/ it is too big for my brain and I'm going to miss things
2/ it is likely duplicating KVM identical code; if so we
should refactor to use common code. In particular because
we can fix bugs once.
> create mode 100644 target/i386/aehd/aehd-accel-ops.c
> create mode 100644 target/i386/aehd/aehd-accel-ops.h
> create mode 100644 target/i386/aehd/aehd-cpu.c
> create mode 100644 target/i386/aehd/aehd-cpu.h
> create mode 100644 target/i386/aehd/aehd-stub.c
> create mode 100644 target/i386/aehd/aehd_i386.h
> --- /dev/null
> +++ b/target/i386/aehd/aehd-accel-ops.c
> @@ -0,0 +1,119 @@
> +/*
> + * QEMU AEHD support
> + *
> + * Copyright IBM, Corp. 2008
> + * Red Hat, Inc. 2008
> + *
> + * Authors:
> + * Anthony Liguori <aliguori@us.ibm.com>
> + * Glauber Costa <gcosta@redhat.com>
In various files you add in this series you use incorrect
author / (c). While you copy/paste their implementation,
they didn't authored this AEHD implementation (which is based
on their work).
next prev parent reply other threads:[~2023-03-03 10:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 2:26 [PATCH 1/6] Add the Android Emulator hypervisor driver (AEHD) accelerator Haitao Shan
2023-03-03 2:26 ` [PATCH 2/6] Add a few AEHD headers Haitao Shan
2023-03-03 2:26 ` [PATCH 3/6] Add the aehd-apic device type Haitao Shan
2023-03-03 9:59 ` Philippe Mathieu-Daudé
2023-03-03 18:36 ` Haitao Shan
2023-03-03 2:26 ` [PATCH 4/6] Add the aehd-ioapic " Haitao Shan
2023-03-03 10:03 ` Philippe Mathieu-Daudé
2023-03-03 2:26 ` [PATCH 5/6] Add the aehd-i8259 " Haitao Shan
2023-03-03 10:09 ` Philippe Mathieu-Daudé
2023-03-03 18:56 ` Haitao Shan
2023-03-03 2:26 ` [PATCH 6/6] Add the AEHD implementation Haitao Shan
2023-03-03 10:15 ` Philippe Mathieu-Daudé [this message]
2023-03-03 18:53 ` Haitao Shan
2023-03-03 7:33 ` [PATCH 1/6] Add the Android Emulator hypervisor driver (AEHD) accelerator Michael S. Tsirkin
2023-03-03 10:19 ` Philippe Mathieu-Daudé
2023-03-03 10:25 ` Philippe Mathieu-Daudé
2023-03-03 17:25 ` Haitao Shan
2023-03-03 17:24 ` Haitao Shan
2023-03-03 17:29 ` Daniel P. Berrangé
2023-03-03 17:41 ` Haitao Shan
2023-03-03 17:20 ` Haitao Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb74ad1-a228-4a63-a01b-70e935de57d0@linaro.org \
--to=philmd@linaro.org \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=emu-dev@google.com \
--cc=haitao.shan@google.com \
--cc=hshan@google.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).