From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F79C0044D for ; Mon, 16 Mar 2020 20:21:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFBD9205ED for ; Mon, 16 Mar 2020 20:21:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFBD9205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDwEp-000281-Vt for qemu-devel@archiver.kernel.org; Mon, 16 Mar 2020 16:21:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40328) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDwEA-0001ip-Ja for qemu-devel@nongnu.org; Mon, 16 Mar 2020 16:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDwE9-0008LM-AL for qemu-devel@nongnu.org; Mon, 16 Mar 2020 16:20:46 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:44675) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDwE9-000800-0I for qemu-devel@nongnu.org; Mon, 16 Mar 2020 16:20:45 -0400 Received: from [192.168.100.1] ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MiZkX-1jpRpz2oad-00fgpB; Mon, 16 Mar 2020 21:20:28 +0100 Subject: Re: [PATCH v3 1/4] scripts: add a script to generate syscall_nr.h To: Taylor Simpson , "qemu-devel@nongnu.org" References: <20200316085620.309769-1-laurent@vivier.eu> <20200316085620.309769-2-laurent@vivier.eu> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: Date: Mon, 16 Mar 2020 21:20:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:X0uQP34Srh/RFa0ekfg46PVs1MGbqRfN/OgmqmK+cBfoLyZuvKK YiwNZBdxxcPIkN8Iv5LRmkwLkoehZ7eamjjwTawHdoiAJTdXvpJ/QflwozC5+5LTV5iUkdQ 6dUbXV2q/XtXHveUIGiCipejpNISsNd1IbENlmvVRO7qALcplmf8YH+CspMmblhjsEovyw7 SpDvmrWy2XA3h8rjdkfxA== X-UI-Out-Filterresults: notjunk:1;V03:K0:xCKFJmrOHzQ=:lFpDqd3UnmuvIupmQ8V2sc G07rgli/ILl/GNl5vytl4AB6S2mvO3QBkISHnNh7+Gl/DcAiIlYcoh3KCqY/aAdtXpa5dIuVO +6eUreDoxmNqabdCNhI9tQZ6xNHn7RyOxIr5cfXgUm8VBjfnuVZSLl1n5jnBwTxSH6EUUqgQc 9UjdSmxiB5kK8NN5lNNccniSJNprLePmU3JDEVM5nkgG3uGhftF+Gaerat4Z9nAYagxhPWSwJ IJXLfn1zx1FD1ISLIPm//VvssHku3Ebl79XYI7P8WaO6OHSkxanhSfMl38fB+7TijuawCAuqi 2pTiIkfJdjZMqUY8oeIJ0h+IV1H3paEgqEx/SWU+cd7sSoTN2o5wh0uKk1VVzocbb6tGcG1Yz stTT+vWhvH4zlwvqfSzwIQVahJi2B+c6pI57u7lwS1GSyizppVheTAtGQ6C1b8MnTJgMJznMe ClLJ7qmbmPCRqFD2Rbss3wTv/yYqubU9VGC8bd0Bm1x6DN9tfljwrsNaykGc0isWozxiJFkUj OBLXBb30/LDLZjBnhqmCCqEXOxBfeacvtPmiOf6Lasv/w8GoWsTiRZY3G08m8R7EfSkgo8S3/ C1FTaqjSDlwUncFv3ama+CQr2YmRau5izCO8MXjkdi4eTurs+zEX0FQfaYVO7a3GLJO4kuuEG z1TV2zWFTssrTTBGqknwbrcwK2kbGUs78FVOWtgGWjtMhdV9y2PL3b35A01lTJoga2CYWLlwc NlrAAxYbHkxuRDDFlalRnmayfCF3zMbjNj5ao7+bWpnIgxAH6/p3XrrAgDXlVMSXA2Yvf/EKp vA4ffcQOUG705bo0NXAdo5DLxKFqw+OYw4mpXLge4rvG5Xp0JviRBjpKBfh1vBDGAAJUz4H X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.13 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , Riku Voipio , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 16/03/2020 à 20:27, Taylor Simpson a écrit : > > >> Le 16/03/2020 à 17:21, Taylor Simpson a écrit : >>> >>> >>>> -----Original Message----- >>>> From: Laurent Vivier >>>> Sent: Monday, March 16, 2020 3:56 AM >>>> To: qemu-devel@nongnu.org >>>> Cc: Laurent Vivier ; Richard Henderson >>>> ; Riku Voipio ; Taylor >>>> Simpson ; Alistair Francis >>>> >>>> Subject: [PATCH v3 1/4] scripts: add a script to generate syscall_nr.h >>>> >>>> This script is needed for targets based on asm-generic syscall numbers >>>> generation >>>> >>>> + >>>> +filter_defines() >>>> +{ >>>> + grep -e "#define __NR_" -e "#define __NR3264" >>> >>> For Hexagon, we're still running a 4.9 kernel. When I tried out this script on >> that code base, there are a handful of these >>> #undef __NR_syscalls >>> #define __NR_syscalls 291 >>> This works fine with normal C preprocessing, and the last one wins. >> However, when the #undef's are filtered out, it lease to build errors from >> multiple #define's of TARGET_NR_syscalls. AFAIK, qemu doesn't use this, so >> it should be OK to filter out. So, I changed the above line to >>> grep -e "#define __NR_" -e "#define __NR3264" | grep -v >> "__NR_syscalls" >>> >>> If you're OK incorporating that now, great! Otherwise, I'll add it to the >> Hexagon RFC patch series until we get to a newer kernel. >> >> Sorry, I've just sent the pull-request. >> >> Add it to your RFC, please. > > Sure. > >> >> It's why this script is only an helper, so it means once the file is >> generated it can be edited before being committed. > > Oh, I thought the goal was to have them all generated. That's why I suggested generating the "Do not modify" comment. The "Do not modify" is a good idea: people will re-run the script instead of editing directly the file, but then it can be adjusted. Thanks, Laurent