From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EEEC433EF for ; Fri, 3 Sep 2021 19:28:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D53A60F92 for ; Fri, 3 Sep 2021 19:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D53A60F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMErr-0008Rr-K7 for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 15:28:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMEpg-0004ZC-Uz for qemu-devel@nongnu.org; Fri, 03 Sep 2021 15:26:38 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:55855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMEpZ-0007Mz-74 for qemu-devel@nongnu.org; Fri, 03 Sep 2021 15:26:36 -0400 Received: by mail-wm1-x334.google.com with SMTP id g135so4149407wme.5 for ; Fri, 03 Sep 2021 12:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fEOMvnRt3u1MPJ0C48yTmkBQGXP7tFiEG+N6OQmYsjo=; b=P2pSCTQReq/NfuXlGzp+sOy6fpIESWIEw5CfGmWWhoHA6QU+aMtGRPT5QwL3G7cqaX qlsJZNSo19g2KqvrO+0vsMCULVfBC1SABLzWXL3a52khd1/0oDU5kA8ctU2xTA2t2tJg TFzPP5t9Z0ipMKdEPUNDpIthHRx7kRD5sydRKqae+dDdnRI3e3deHofjj3Dbhwx575FJ 67HrHdc6flCcR1dTNOCqIgJe8YuQnAbaVUFvr1U0suIQSXf+wJ2/6/OFYotwZQAmxKck fROsg+wFBaKOY8CGviS1GZZW/PbZy2B4duETnBoUcub93bFwOnrH0QDrH6sINCV4Iy4E ZREQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fEOMvnRt3u1MPJ0C48yTmkBQGXP7tFiEG+N6OQmYsjo=; b=Hya/BsZ2WzLca4PdxbwBLyiPnPU8aV+U/jM+qfX6cwuaNXTkJj6pRvuMLajk2J6S6B Y4qSWA9hSmy7LLq9NDqqycewIbM1ZyXc3BT1D+YEh+Wdl17nY3n2mKlfcRwKdXmSAazO f+sq0Qj9ZI1E6pryK4dP4r0v/SqIjBVQ6+Vnc8aT8ITdX3J0PyA/6cYHjBlNtmpMvibe aiy3UjJkhslDtBPg+9THlmnjo3VmnU1GhL522y2F6XtN3VMNObbdjGvwifTKn3dkGxit TBwynKqdB+G6tKW6OjjTOfMrnaKHt6zZA2tUhxmIGHGORc/jE7swjAwZ/JkHEhZzSi+R olPg== X-Gm-Message-State: AOAM530uWtdyB1xyNAyVRTHFAbC5/fhZvqwjBCPGZXhqtpwGkZjoelsG 5z7lINO37xUN3hpKOnitbpus+Q== X-Google-Smtp-Source: ABdhPJzPb7c7nn36sN0yMAj5ZlOkqXuuz0MVoi48d+Irv6UFiriYZ9JbXNphN9ib9SQl4UPKFUyy2g== X-Received: by 2002:a7b:c255:: with SMTP id b21mr296138wmj.44.1630697186866; Fri, 03 Sep 2021 12:26:26 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id f17sm134080wrt.63.2021.09.03.12.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 12:26:26 -0700 (PDT) Subject: Re: [PATCH 23/24] accel/tcg: Restrict TCGCPUOps::cpu_exec_interrupt() to sysemu To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210902151715.383678-1-f4bug@amsat.org> <20210902151715.383678-24-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 21:26:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902151715.383678-24-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.888, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Bin Meng , Mark Cave-Ayland , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Warner Losh , Marek Vasut , Yoshinori Sato , qemu-ppc@nongnu.org, Artyom Tarasenko , Aleksandar Rikalo , Eduardo Habkost , Kyle Evans , Greg Kurz , qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Chris Wulff , Laurent Vivier , Palmer Dabbelt , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/2/21 5:17 PM, Philippe Mathieu-Daudé wrote: > All targets call TCGCPUOps::cpu_exec_interrupt() from sysemu code. > Move its declaration to restrict it to system emulation. > Extend the code guarded and remove the user-mode assertion. > Also restrict the static inlined need_replay_interrupt() method to > avoid a "defined but not used" warning. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/tcg-cpu-ops.h | 4 ++-- > accel/tcg/cpu-exec.c | 13 +++++++------ > 2 files changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~